Remove web3[tester] dep from core dependencies#160
Remove web3[tester] dep from core dependencies#160njgheorghita wants to merge 1 commit intoethpm:masterfrom
Conversation
|
|
||
| def run(self): | ||
| _develop.run(self) | ||
| check_call(["pip", "install", f"web3[tester]>={WEB3_VERSION}"]) |
There was a problem hiding this comment.
I don't think this will work when it's installed via a wheel (but I'm not positive) you should confirm before proceeding. Generally this is in the realm of things that I consider bad ideas that don't end up reliably working beyond the development environment.
There was a problem hiding this comment.
I agree it's a little iffy, but isn't this a command that will only be run in a development/testing environment?
There was a problem hiding this comment.
I don't think this will work when it's installed via a wheel (but I'm not positive)
This is true from what I've read.
isn't this a command that will only be run in a development/testing environment?
I feel the same way, but I guess it's possible other projects might have a core dependency on ethpm[dev] - which would be weird, but possible. IMO though, this is the cleanest solution I've come across for removing the web3[tester] splinter from ethpm's core dependencies - and worth the trade-off, but I could be misjudging this.
|
given this is a dependency of web3.py I'm nervious, but I don't have a specific failure in mind, only the generic idea that this misbehaves in some un-expected way. Thoughts on just documenting the appropriate installation steps well? |
3 participants
What was wrong?
#137 (comment)
Fixes #140
Core dependency of
web3[tester]causes when doing a base install.Thanks @mikeshultz for the solution!
Cute Animal Picture