Build release docker images on native runners, drop QEMU#46
Open
barnabasbusa wants to merge 1 commit into
Open
Build release docker images on native runners, drop QEMU#46barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
Mirrors the dora build template: goreleaser builds only the binaries and the GitHub release, and the multi-arch docker images are built on native runners (amd64 on ubuntu-latest, arm64 on ubuntu-24.04-arm) then merged into the version + latest tags with buildx imagetools. Removes the last use of QEMU. - .goreleaser.yaml: drop dockers/docker_manifests; .goreleaser.Dockerfile removed (images build from the main Dockerfile, same as build-dev) - docker actions at latest: setup-buildx-action v4.1.0, login-action v4.2.0, goreleaser-action v7.2.2 - image tags preserved: ethpandaops/rpc-snooper:<version> and :<suffix->latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes QEMU from the release pipeline by building the multi-arch docker images on native runners, mirroring ethpandaops/dora's build template.
goreleaser.yaml: goreleaser now builds only the binaries + GitHub release. The docker images are built per-arch on native runners —build_amd64_docker_image(ubuntu-latest) andbuild_arm64_docker_image(ubuntu-24.04-arm) — thenbuild_multiarch_imagemerges them into the version + latest tags withdocker buildx imagetools create. TheSet up QEMUstep is gone..goreleaser.yaml: droppeddockers:/docker_manifests:(goreleaser no longer builds images)..goreleaser.Dockerfileremoved — release images now build from the mainDockerfile, same asbuild-dev.yml.setup-buildx-actionv4.1.0,login-actionv4.2.0,goreleaser-actionv7.2.2.Why native runners (not Dockerfile cross-compile or QEMU)
On a native runner the multi-arch base image is pulled for that arch and
RUNsteps execute natively — no emulation, and no Dockerfile changes needed. QEMU was only required because the old release built the arm64 image on an amd64 runner.Tags (unchanged from goreleaser output)
ethpandaops/rpc-snooper:<version>(leadingvstripped)ethpandaops/rpc-snooper:<suffix->latest(e.g.latest, ordencun-latestfor avX.Y.Z-dencuntag):<version>-amd64/:<version>-arm64Notes
.goreleaser.yamlstill has two pre-existing deprecation warnings (version: 2,snapshot.name_template) — left untouched, out of scope.Test plan
vX.Y.Z) and confirmethpandaops/rpc-snooper:X.Y.Z+:latestare published as multi-arch (amd64+arm64) with no QEMU step in the logs.vX.Y.Z-suffixtag publishes:X.Y.Z-suffix+:suffix-latestand the GitHub release is marked prerelease.docker run ethpandaops/rpc-snooper:X.Y.Z --help).