Repository navigation
Add generic, batch, and distributed signing profiles - #29
Draft
wemeetagain wants to merge 1 commit into
Draft
wemeetagain wants to merge 1 commit into
wemeetagain wants to merge 1 commit into
Conversation
Extract the signing request union for reuse, add safe generic signing and same-duty multi-key batches, and define an optional coordinator-to-participant threshold signing profile with discovery, partial-signature endpoints, recovery rules, and a deterministic 2-of-3 vector.
1 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SigningRequestunion and add aGENERICsigning requestMotivation
The existing API standardizes the validator-client-to-signer boundary, but threshold deployments also need a consistent coordinator-to-participant boundary. This adds that profile without changing the existing full-signature endpoint or requiring distributed-signing details in validator clients.
This also addresses the generic-signing and batching use cases discussed in #26 and #19 while keeping them additive to the existing API.
API additions
POST /api/v1/eth2/signfor same-duty multi-key batch signingGET /api/v1/eth2/distributed/accountsGET /api/v1/eth2/distributed/accounts/{identifier}POST /api/v1/eth2/distributed/signPOST /api/v1/eth2/distributed/sign/{identifier}The existing
POST /api/v1/eth2/sign/{identifier}endpoint remains the full-signature endpoint. Distributed signing endpoints return partial signatures and participant metadata only.Compatibility and release note
All new request types and endpoints are additive. The specification version is intentionally unchanged because #28 currently claims
v1.4.0; once that work lands, this branch can be rebased and its new signing types incorporated into the centralizedSigningRequestunion.Validation
/publicKeyscamel-case warninggit diff --checkRelated: #19, #26