Repository navigation
Conversation
MysticRyuujin
approved these changes
Mar 16, 2026
Contributor
|
I'm not against this but Gloas will come with some big changes related to validator registrations / proposer preferences that may require a bigger change in the Remote Signing API. We should probably wait and see how ethereum/beacon-APIs#570 plays out. I don't think it would be worth making changes to this endpoint for Fusaka only. |
Author
|
Converting to draft until gloas solidifies |
jshufro
marked this pull request as draft
March 18, 2026 20:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In implementing the ValidatorRegistrationSigning portion of this API, I discovered that the signing domain is computed from:
This is distinct from other types, where the domain is computed from:
It seems like we deliberately use a mask based on a chain id when setting fork versions, so the genesis fork version is sensibly unique to a specific network.
Adding the genesis_fork_version to ValidatorRegistrationSigning as an optional (at first) field provides a clean migration path across versions.