Skip to content

refactor(spec-specs): rename inclusion_list_satisfied field#3092

Merged
spencer-tb merged 1 commit into
ethereum:eips/bogota/eip-7805from
jihoonsong:eips/bogota/eip-7805-rename-inclusion-list-satisfied
Jul 3, 2026
Merged

refactor(spec-specs): rename inclusion_list_satisfied field#3092
spencer-tb merged 1 commit into
ethereum:eips/bogota/eip-7805from
jihoonsong:eips/bogota/eip-7805-rename-inclusion-list-satisfied

Conversation

@jihoonsong

Copy link
Copy Markdown
Member

🗒️ Description

This PR renames is_inclusion_list_satisfied to inclusion_list_satisfied according to the latest engine APIs change.

🔗 Related Issues or PRs

ethereum/execution-apis#609

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Verifying Changes:
    just static
  • All: PR title have the form <type>(<area>):, where <type> and <area> come from an approrpriate C-<type>, respectively A-<area>, label. The title should match the a target squash commit message.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: Add the following docstring to manually enhanced tests from ./tests/ported_static/:
    @manually-enhanced: Do not overwrite. Post-state expectations corrected
    manually (see PR #2784).
    

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (eips/bogota/eip-7805@0b85a96). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/ethereum/forks/amsterdam/fork.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             eips/bogota/eip-7805    #3092   +/-   ##
=======================================================
  Coverage                        ?   84.33%           
=======================================================
  Files                           ?      535           
  Lines                           ?    32913           
  Branches                        ?     3025           
=======================================================
  Hits                            ?    27756           
  Misses                          ?     4682           
  Partials                        ?      475           
Flag Coverage Δ
unittests 84.33% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb changed the title Rename inclusion_list_satisfied field refactor(spec-specs): rename inclusion_list_satisfied field Jul 3, 2026

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx

@spencer-tb spencer-tb merged commit 6720f62 into ethereum:eips/bogota/eip-7805 Jul 3, 2026
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants