feat(test-consume,deps): use register_multi_test_client to fix client logs in test reports#2476
Merged
spencer-tb merged 2 commits intoMar 20, 2026
Conversation
register_multi_test_client to fix client logs in test reportsregister_multi_test_client to fix client logs in test reports
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2476 +/- ##
===================================================
+ Coverage 85.97% 86.01% +0.04%
===================================================
Files 599 599
Lines 36916 36904 -12
Branches 3771 3771
===================================================
+ Hits 31738 31744 +6
+ Misses 4560 4551 -9
+ Partials 618 609 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No changes for single-test hive test/clients; this ethereum-hive release updates the name of the method and endpoint for registering tests agains a multi-test client, cf ethereum/hive-python-api#15.
4ee86c3 to
fc09e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Requires: ethereum/hive#1402- now merged.This PR activates client log segment capturing via the Hive backend for correct client log reporting for enginex, which uses multi-test clients. See ethereum/hive#1402 for more details.
The corresponding
ethereum-hivechanges were added in ethereum/hive-python-api#15 and published inv0.1.0a5.🔗 Related Issues or PRs
Builds on:
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture
🐢