Skip to content

feat(test-consume,deps): use register_multi_test_client to fix client logs in test reports#2476

Merged
spencer-tb merged 2 commits into
forks/amsterdamfrom
experiments/enginex-fix-test-reporting
Mar 20, 2026
Merged

feat(test-consume,deps): use register_multi_test_client to fix client logs in test reports#2476
spencer-tb merged 2 commits into
forks/amsterdamfrom
experiments/enginex-fix-test-reporting

Conversation

@danceratopz

@danceratopz danceratopz commented Mar 11, 2026

Copy link
Copy Markdown
Member

🗒️ Description

Requires: ethereum/hive#1402 - now merged.

This PR activates client log segment capturing via the Hive backend for correct client log reporting for enginex, which uses multi-test clients. See ethereum/hive#1402 for more details.

The corresponding ethereum-hive changes were added in ethereum/hive-python-api#15 and published in v0.1.0a5.

🔗 Related Issues or PRs

Builds on:

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

🐢

@danceratopz danceratopz self-assigned this Mar 11, 2026
@danceratopz danceratopz added C-feat Category: an improvement or new feature A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume labels Mar 11, 2026
@danceratopz danceratopz changed the title feat(test-consume): use register_multi_test_client to fix client logs in test reports feat(test-consume,deps): use register_multi_test_client to fix client logs in test reports Mar 11, 2026
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.01%. Comparing base (8a0fc69) to head (fc09e89).
⚠️ Report is 24 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2476      +/-   ##
===================================================
+ Coverage            85.97%   86.01%   +0.04%     
===================================================
  Files                  599      599              
  Lines                36916    36904      -12     
  Branches              3771     3771              
===================================================
+ Hits                 31738    31744       +6     
+ Misses                4560     4551       -9     
+ Partials               618      609       -9     
Flag Coverage Δ
unittests 86.01% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

No changes for single-test hive test/clients; this ethereum-hive release updates the name of the method and endpoint for registering tests agains a multi-test client, cf ethereum/hive-python-api#15.
@danceratopz danceratopz force-pushed the experiments/enginex-fix-test-reporting branch from 4ee86c3 to fc09e89 Compare March 17, 2026 21:30
@danceratopz danceratopz marked this pull request as ready for review March 17, 2026 22:19
@danceratopz danceratopz requested a review from spencer-tb March 17, 2026 22:19

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit 7bc95e1 into forks/amsterdam Mar 20, 2026
25 of 29 checks passed
@danceratopz danceratopz deleted the experiments/enginex-fix-test-reporting branch March 31, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants