feat(tooling): align versioning scheme to 6.19.0#2464
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2464 +/- ##
================================================
Coverage 86.25% 86.25%
================================================
Files 599 599
Lines 37032 37032
Branches 3795 3795
================================================
Hits 31943 31943
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| - `COMPAT` is incremented when a release contains a backwards-incompatible change to an EELS' interface (Python API, command line tools, etc.) | ||
| - `HARDFORK` is the number of hardforks included in the release after Frontier. | ||
| - `HARDFORK` is the number of named hardforks included in the release after Frontier. Parameter-only forks (such as BPO forks) do not increment this value. |
There was a problem hiding this comment.
Glacier forks are "parameter-only" forks, so you'd need to account for them here.
I'd still prefer to just bump HARDFORK for any hardfork, including BPOs.
There was a problem hiding this comment.
Ah, true yeah.
Let's debate this at the Wednesday meeting.
| The following table is a hypothetical complete example of all of the releases between `6.19.0rc1.dev1` and `7.20.0`, in order from oldest at the top to the newest at the bottom. | ||
|
|
||
| | Fork | Description | Version Number | | ||
| | ---------- | ------------------ | ------------------ | | ||
| | amsterdam | preview of devnet1 | `6.19.0rc1.dev1` | | ||
| | amsterdam | preview of devnet1 | `6.19.0rc1.dev2` | | ||
| | amsterdam | preview of devnet1 | `6.19.0rc1.dev3` | | ||
| | | | | | ||
| | amsterdam | finalize devnet1 | `6.19.0rc1` | | ||
| | | | | | ||
| | amsterdam | devnet1 bugfix | `6.19.0rc1.post1` | | ||
| | amsterdam | devnet1 bugfix | `6.19.0rc1.post2` | | ||
| | | | | | ||
| | amsterdam | finalize devnet2 | `6.19.0rc2` | | ||
| | | | | | ||
| | amsterdam | finalize mainnet | `6.19.0` | | ||
| | | | | | ||
| | amsterdam | BPO fork | `6.19.1` | | ||
| | amsterdam | BPO fork | `6.19.2` | | ||
| | amsterdam | packaging fix | `6.19.3` | | ||
| | | | | | ||
| | amsterdam | breaking change | `7.19.0` | | ||
| | | | | | ||
| | next-fork | preview of devnet1 | `7.20.0rc1.dev1` | | ||
| | | | | | ||
| | next-fork | finalize devnet1 | `7.20.0rc1` | | ||
| | | | | | ||
| | next-fork | finalize mainnet | `7.20.0` | |
There was a problem hiding this comment.
I'm not sure changing the examples adds much, they're effectively the same thing, just bigger numbers.
There was a problem hiding this comment.
I figured it should align, unless there is some reason not to?
66c93fc to
f53d6be
Compare
f53d6be to
1c06511
Compare
|
This PR has had no recent activity and has been marked as stale. |
🗒️ Description
Align versioning schemes for post-WELD world.
FORKversion, and are instead part of thePATCHversioning.🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Moving From EEST to EELS Releases
release_fixture_full.yamlandrelease_fixture_feature.yaml:--repo ethereum/execution-spec-tests→--repo ethereum/execution-specsEEST_RELEASE_TOKENsecret withgithub.token(same repo, no cross-repo auth needed)hive-consume.yaml:ethereum/execution-spec-tests→ethereum/execution-specsreleases.py(consumer code):ethereum/execution-specsto supported reposClient teams:
ethereum/execution-spec-teststoethereum/execution-specsCute Animal Picture
A Philippine Tarsier - Photo by David Haring License does not indicate usage restrictions.