-
Notifications
You must be signed in to change notification settings - Fork 516
Add initial FOCIL spec #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jihoonsong
wants to merge
22
commits into
ethereum:main
Choose a base branch
from
jihoonsong:focil
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4bbd6d1
Add initial FOCIL spec
jihoonsong 7854b10
Move EIP-7805 spec under experimental folder
jihoonsong 7ca6997
Use primitive type instead of new structures to not make dependency
jihoonsong 44cb2c1
Specify the upper bound of a list of inclusion lists
jihoonsong 011713f
Add rules to ignore any blob transactions in the ILs
jihoonsong eabca93
Rebase onto Osaka
jihoonsong d82a82d
Reflect changes in the queue
jihoonsong 06a2a6e
Revamp and rebase to Bogota
jihoonsong 37e6278
Reflect #786 to Botoga
jihoonsong 3cb94d5
Remove redundant `status` modification statement
jihoonsong 660fe42
Use `blockHash` instead of `parentHash`
jihoonsong 259d803
Reflect #774 to Botoga
jihoonsong cbcb257
Reflect #796 to Botoga
jihoonsong d2f26ef
Add RPC schemas for Bogota
jihoonsong 563e36e
Add getinclusionlistv and getInclusionListV to wordlist
jihoonsong 62de4bd
`INCLUSION_LIST_UNSATISFIED` payloads are a subset of `VALID` payloads
jihoonsong 9a5c295
Specify to must consider IL transactions while building a payload
jihoonsong 59f7803
Add PayloadStatusV2
jihoonsong e38c956
Use PayloadStatusV2 in Bogota
jihoonsong ca05274
Specify IL enforcement during the payload validation process
jihoonsong 65191fc
Specify IL enforcement for different branches
jihoonsong a56ea08
Replace `latestInclusionListSatisfiedHash` with `inclusionListSatisfied`
jihoonsong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| # Engine API -- Bogota | ||
|
|
||
| Engine API changes introduced in Bogota. | ||
|
|
||
| This specification is based on and extends [Engine API - Amsterdam](./amsterdam.md) specification. | ||
|
|
||
| ## Table of contents | ||
|
|
||
| <!-- START doctoc generated TOC please keep comment here to allow auto update --> | ||
| <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | ||
|
|
||
| - [Constants](#constants) | ||
| - [Structures](#structures) | ||
| - [PayloadAttributesV5](#payloadattributesv5) | ||
| - [PayloadStatusV2](#payloadstatusv2) | ||
| - [Routines](#routines) | ||
| - [Payload building](#payload-building) | ||
| - [Methods](#methods) | ||
| - [engine_newPayloadV6](#engine_newpayloadv6) | ||
| - [Request](#request) | ||
| - [Response](#response) | ||
| - [Specification](#specification) | ||
| - [engine_getInclusionListV1](#engine_getinclusionlistv1) | ||
| - [Request](#request-1) | ||
| - [Response](#response-1) | ||
| - [Specification](#specification-1) | ||
| - [engine_forkchoiceUpdatedV5](#engine_forkchoiceupdatedv5) | ||
| - [Request](#request-2) | ||
| - [Response](#response-2) | ||
| - [Specification](#specification-2) | ||
| - [Update the methods of previous forks](#update-the-methods-of-previous-forks) | ||
| - [Amsterdam API](#amsterdam-api) | ||
|
|
||
| <!-- END doctoc generated TOC please keep comment here to allow auto update --> | ||
|
|
||
| ## Constants | ||
|
|
||
| | Name | Value | | ||
| | - | - | | ||
| | `MAX_BYTES_PER_INCLUSION_LIST` | `uint64(8192) = 2**13` | | ||
|
|
||
| ## Structures | ||
|
|
||
| ### PayloadAttributesV5 | ||
|
|
||
| This structure has the syntax of [`PayloadAttributesV4`](./amsterdam.md#payloadattributesv4) and appends a single field: `inclusionListTransactions`. | ||
|
|
||
| - `timestamp`: `QUANTITY`, 64 Bits - value for the `timestamp` field of the new payload | ||
| - `prevRandao`: `DATA`, 32 Bytes - value for the `prevRandao` field of the new payload | ||
| - `suggestedFeeRecipient`: `DATA`, 20 Bytes - suggested value for the `feeRecipient` field of the new payload | ||
| - `withdrawals`: `Array of WithdrawalV1` - Array of withdrawals, each object is an `OBJECT` containing the fields of a `WithdrawalV1` structure. | ||
| - `parentBeaconBlockRoot`: `DATA`, 32 Bytes - Root of the parent beacon block. | ||
| - `slotNumber`: `QUANTITY`, 64 Bits - value for the `slotNumber` field of the new payload | ||
| - `targetGasLimit`: `QUANTITY`, 64 Bits - target value for the `gasLimit` field of the new payload | ||
| - `inclusionListTransactions`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | ||
|
|
||
| ### PayloadStatusV2 | ||
|
|
||
| This structure has the syntax of `PayloadStatusV1` and appends a single field: `inclusionListSatisfied` | ||
|
|
||
| - `status`: `enum` - `"VALID" | "INVALID" | "SYNCING" | "ACCEPTED"` | ||
| - `latestValidHash`: `DATA|null`, 32 Bytes - the hash of the most recent *valid* block in the branch defined by payload and its ancestors | ||
| - `validationError`: `String|null` - a message providing additional details on the validation error if the payload is classified as `INVALID`. | ||
| - `inclusionListSatisfied`: `BOOLEAN|null` - whether the payload satisfied the inclusion list constraints if it is deemed `VALID`; `null` otherwise. | ||
|
|
||
| ## Routines | ||
|
|
||
| ### Payload building | ||
|
|
||
| This routine follows the same specification as [Payload building](./paris.md#payload-building) with the following changes to the processing flow: | ||
|
|
||
| 1. Client software **MUST** take `inclusionListTransactions` into account during the payload build process. The built `ExecutionPayload` **MUST** satisfy the inclusion list constraints with respect to `inclusionListTransactions` as defined in [EIP-7805](https://eips.ethereum.org/EIPS/eip-7805). | ||
|
|
||
| ## Methods | ||
|
|
||
| ### engine_newPayloadV6 | ||
|
|
||
| Method parameter list is extended with `inclusionListTransactions`. | ||
|
|
||
| #### Request | ||
|
|
||
| * method: `engine_newPayloadV6` | ||
| * params: | ||
| 1. `executionPayload`: [`ExecutionPayloadV4`](./amsterdam.md#executionpayloadv4). | ||
| 2. `expectedBlobVersionedHashes`: `Array of DATA`, 32 Bytes - Array of expected blob versioned hashes to validate. | ||
| 3. `parentBeaconBlockRoot`: `DATA`, 32 Bytes - Root of the parent beacon block. | ||
| 4. `executionRequests`: `Array of DATA` - List of execution layer triggered requests. Each list element is a `requests` byte array as defined by [EIP-7685](https://eips.ethereum.org/EIPS/eip-7685). The first byte of each element is the `request_type` and the remaining bytes are the `request_data`. Elements of the list **MUST** be ordered by `request_type` in ascending order. Elements with empty `request_data` **MUST** be excluded from the list. | ||
| 5. `inclusionListTransactions`: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | ||
|
|
||
| #### Response | ||
|
|
||
| * result: [`PayloadStatusV2`](#payloadstatusv2) | ||
| * error: code and message set in case an exception happens while processing the payload. | ||
|
|
||
| #### Specification | ||
|
|
||
| This method follows the same specification as [`engine_newPayloadV5`](./amsterdam.md#engine_newpayloadv5) with the following changes: | ||
|
|
||
| 1. Client software **MUST** return `-38005: Unsupported fork` error if the `timestamp` of the payload does not fall within the time frame of the Bogota fork. | ||
|
|
||
| 2. Client software **MUST** set `inclusionListSatisfied` in the following way: | ||
|
|
||
| 1. If the payload is deemed `VALID`, `inclusionListSatisfied` **MUST** be set to whether the payload satisfied the inclusion list constraints. | ||
|
|
||
| 2. Otherwise, `inclusionListSatisfied` **MUST** be `null`. | ||
|
|
||
| 3. Client software **MUST** retain `inclusionListTransactions` for a payload with `ACCEPTED` status. Client software **MAY** discard them once the payload is no longer the tip of a branch. Client software **MUST** use the retained `inclusionListTransactions` if it later checks whether the payload satisfies the inclusion list constraints. | ||
|
|
||
| ### engine_getInclusionListV1 | ||
|
|
||
| #### Request | ||
|
|
||
| * method: `engine_getInclusionListV1` | ||
| * params: | ||
| 1. `blockHash`: `DATA`, 32 Bytes - block hash of the block upon which the inclusion list should be built. | ||
|
|
||
| * timeout: 1s | ||
|
|
||
| #### Response | ||
|
|
||
| * result: `Array of DATA` - Array of transaction objects, each object is a byte list (`DATA`) representing `TransactionType || TransactionPayload` or `LegacyTransaction` as defined in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | ||
| * error: code and message set in case an exception happens while getting the inclusion list. | ||
|
|
||
| #### Specification | ||
|
|
||
| 1. Client software **MUST** return `-38001: Unknown payload` error if a block with the given `blockHash` does not exist. | ||
|
|
||
| 2. Client software **MUST** provide a list of transactions for the inclusion list based on the local view of the mempool. The strategy for selecting which transactions to include is implementation dependent. | ||
|
|
||
| 3. Client software **MUST** ensure the byte length of the RLP encoding of the returned transaction list does not exceed `MAX_BYTES_PER_INCLUSION_LIST`. | ||
|
|
||
| 4. Client software **MUST NOT** include any [blob transaction](https://eips.ethereum.org/EIPS/eip-4844#blob-transaction) in the returned transaction list. | ||
|
|
||
| ### engine_forkchoiceUpdatedV5 | ||
|
|
||
| #### Request | ||
|
|
||
| * method: `engine_forkchoiceUpdatedV5` | ||
| * params: | ||
| 1. `forkchoiceState`: [`ForkchoiceStateV1`](./paris.md#forkchoicestatev1). | ||
| 2. `payloadAttributes`: `Object|null` - Instance of [`PayloadAttributesV5`](#payloadattributesv5) or `null`. | ||
| 3. `custodyColumns`: `DATA|null`, 16 Bytes - Interpreted as a bitarray of length `CELLS_PER_EXT_BLOB` indicating which column indices form the CL's custody set, or `null` if the CL does not provide custody services. | ||
| * timeout: 8s | ||
|
|
||
| #### Response | ||
|
|
||
| * result: `object` | ||
| - `payloadStatus`: [`PayloadStatusV2`](#payloadstatusv2), with the same `status` value restrictions as [`engine_forkchoiceUpdatedV4`](./amsterdam.md#engine_forkchoiceupdatedv4). | ||
| - `payloadId`: `DATA|null`, 8 Bytes - identifier of the payload build process or `null` | ||
| * error: code and message set in case an exception happens while the validating payload, updating the forkchoice or initiating the payload build process. | ||
|
|
||
| #### Specification | ||
|
mkalinin marked this conversation as resolved.
|
||
|
|
||
| This method follows the same specification as [`engine_forkchoiceUpdatedV4`](./amsterdam.md#engine_forkchoiceupdatedv4) with the following changes to the processing flow: | ||
|
|
||
| 1. Extend point (8) of the `engine_forkchoiceUpdatedV1` [specification](./paris.md#specification-1) by defining the following sequence of checks that **MUST** be run over `payloadAttributes`: | ||
|
|
||
| 1. `payloadAttributes` matches the [`PayloadAttributesV5`](#payloadattributesv5) structure, return `-38003: Invalid payload attributes` on failure. | ||
|
|
||
| 2. `payloadAttributes.timestamp` does not fall within the time frame of the Bogota fork, return `-38005: Unsupported fork` on failure. | ||
|
|
||
| 2. Extend point (9) of the `engine_forkchoiceUpdatedV1` [specification](./paris.md#specification-1) by defining `payloadStatus.inclusionListSatisfied`: | ||
|
|
||
| 1. If the payload referenced by `forkchoiceState.headBlockHash` is deemed `VALID`, `payloadStatus.inclusionListSatisfied` **MUST** be set to whether the payload satisfied the inclusion list constraints. | ||
|
|
||
| 2. Otherwise, `payloadStatus.inclusionListSatisfied` **MUST** be `null`. | ||
|
|
||
| ### Update the methods of previous forks | ||
|
|
||
| #### Amsterdam API | ||
|
|
||
| For the following methods: | ||
|
|
||
| - [`engine_newPayloadV5`](./amsterdam.md#engine_newpayloadv5) | ||
| - [`engine_forkchoiceUpdatedV4`](./amsterdam.md#engine_forkchoiceupdatedv4) | ||
|
|
||
| a validation **MUST** be added: | ||
|
|
||
| 1. Client software **MUST** return `-38005: Unsupported fork` error if the `timestamp` of payload is greater than or equal to the Bogota activation timestamp. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| - name: engine_getInclusionListV1 | ||
| summary: Obtains an inclusion list built upon the given block hash | ||
| externalDocs: | ||
| description: Method specification | ||
| url: https://github.com/ethereum/execution-apis/blob/main/src/engine/bogota.md#engine_getinclusionlistv1 | ||
| params: | ||
| - name: Block hash | ||
| required: true | ||
| schema: | ||
| $ref: '#/components/schemas/hash32' | ||
| result: | ||
| name: Inclusion list transactions | ||
| schema: | ||
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/bytes' | ||
| errors: | ||
| - code: -38001 | ||
| message: Unknown payload |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.