Specify rep/resp for inclusion lists#5424
Open
jihoonsong wants to merge 2 commits into
Open
Conversation
jihoonsong
force-pushed
the
inclusion-list-req-resp
branch
from
474fd85 to
601df31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specifies
InclusionListsByIndices.Compared to previous req/resp, it adds
inclusion_list_committee_rootin the request content. This is to specify which branch the requester is asking for. Note thatSignedInclusionListthe response also hasinclusion_list_committee_root, which the requester can verify whether the response is for the same branch that they're on. I've added it as adding the 32-bytes information would make it easier for both requester and responder.InclusionListsByIndicesreturns signed objects same with other req/resp. To that end,inclusion_list_storewill be changed to storeSignedInclusionList. This will be handled in the following PR to keep each PR tight and easier to review.