Use rng.randint in get_random_* functions#5415
Open
jtraglia wants to merge 1 commit into
Open
Conversation
jihoonsong
reviewed
Jul 2, 2026
| get_valid_attestation( | ||
| spec, | ||
| state, | ||
| slot=rng.randrange(state.slot - spec.SLOTS_PER_EPOCH + 1, state.slot), |
Member
There was a problem hiding this comment.
Suggested change
| slot=rng.randint(state.slot - spec.SLOTS_PER_EPOCH + 1, state.slot), |
Currently, get_random_attestations is called to construct a block for the next slot, attestations for current slot can also be included.
Also, it doesn't have to start 1 epoch earlier post-Deneb. Something like this works, if we want to be more precise.
if is_post_deneb(spec):
oldest = spec.compute_start_slot_at_epoch(spec.compute_epoch_at_slot(state.slot + 1) - 1)
else:
oldest = state.slot - spec.SLOTS_PER_EPOCH + 1
slot = rng.randint(oldest, state.slot)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5413, @jihoonsong noticed that the
rng.randrangecalls should berng.randintinstead so the maximum value is possible. I would also like for zero to be an option; there's value in testing that too.