Require imported payload for index == 1 attestation gossip#5355
Open
tbenr wants to merge 1 commit into
Open
Conversation
The gossip validation rule for attestations and aggregates that vote the execution payload is present for a past block (`data.index == 1`) only required the payload to have been seen. Require instead that it has been fully imported, i.e. `is_payload_verified` returns `True`, which also guarantees its data is available. Such a vote concerns the payload of a prior block, so by the time the attestation is validated the payload should already be fully imported. Requiring this rather than mere receipt lets a node validate the vote against verified state and its local data availability.
Contributor
Author
but as later discussed in discord, such a clarification should be applied to several "seen" usage in gossip rules since phase0, for consistency. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gossip validation rule for attestations and aggregates that vote the execution payload is present for a past block (
data.index == 1) only required the payload to have been seen. Require instead that it has been fully imported, i.e.is_payload_verifiedreturnsTrue, which also guarantees its data is available.Such a vote concerns the payload of a prior block, so by the time the attestation is validated the payload should already be fully imported. Requiring this rather than mere receipt lets a node validate the vote against verified state and its local data availability.