ci: publish on Node 24 with a pinned npm - #212
Merged
Merged
Conversation
The publish-npm job ran on `node-version: 25` and then did
`npm install -g npm@latest`. npm 12 requires
`^22.22.2 || ^24.15.0 || >=26.0.0`, which excludes Node 25, so the
upgrade step died with EBADENGINE and the package could never be
published:
npm error code EBADENGINE
npm error Not compatible with your version of node/npm: npm@12.0.2
npm error Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error Actual: {"node":"v25.9.0","npm":"11.12.1"}
Move to Node 24, an LTS line supported by every npm 11.x and 12.x, and
pin the upgrade to `npm@^11.5.1` — a range rather than `@latest`, so the
next npm major dropping this Node line cannot silently break publishing
fleet-wide again. 11.5.1 is the minimum for OIDC trusted publishing.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting/agentic_review on this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
publish-npmran onnode-version: 25and thennpm install -g npm@latest.npm 12 requires
^22.22.2 || ^24.15.0 || >=26.0.0— Node 25 is excluded — sothe upgrade step died and this package could never be published:
The fix
node-version: 25→24(an LTS line every npm 11.x and 12.x supports).npm@latest→npm@^11.5.1— a range, not@latest, so the next npm majordropping this Node line can't silently break publishing fleet-wide again.
11.5.1 is the minimum for OIDC trusted publishing.
No other change. Same fix as the merged pilot, ether/ep_align#227.
🤖 Generated with Claude Code
https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw