fix: repair pnpm run lint and gate it in CI

[JohnMcLear]

Problem

pnpm run lint is broken in this repo (and in ~80 other ether/* plugin
repos). devDependencies.typescript was ^7.0.2, which resolves to the
native TypeScript 7 port. TS 7 no longer exposes the legacy compiler API
that ts-api-utils -- pulled in by @typescript-eslint via
eslint-config-etherpad -- depends on, so the config threw at load time:

Cannot read properties of undefined (reading 'Intrinsic')

That takes the entire ESLint run down, so pnpm run lint failed before
linting a single file. It went unnoticed because lint was never run in CI.

Changes

Dependencies + CI

• typescript pinned to ~6.0.3. eslint-config-etherpad@5 declares a
  typescript: ">=4.8.4 <6.1.0" peer range, so a future TypeScript major
  now fails loudly at install time instead of silently breaking lint.
• eslint-config-etherpad bumped to ^5.0.0.
• pnpm-lock.yaml regenerated. The diff is large because TypeScript 7
  ships ~20 per-platform native binaries that TypeScript 6 does not.
• New reusable .github/workflows/lint.yml, called from
  test-and-release.yml, with lint added to the release job's
  needs: list so lint failures block a release.

Lint findings

With ESLint running again it reported 6 error(s), fixed in separate
commit(s) so the dependency change above stays reviewable:

• eslint --fix (own commit): implicit-arrow-linebreak in static/tests/backend/specs/filemenu.js.
• mocha/no-synchronous-tests x5: the reported it/before callbacks are now async.
• max-len: the render helper's arguments are wrapped onto a second line.

All fixes are mechanical and behaviour-preserving -- no test expectation,
hook or runtime behaviour changes.

pnpm run lint now exits 0.

This matches the already-merged ether/ep_cursortrace#117,
ether/ep_clear_formatting#96 and ether/ep_git_commit_saved_revision#107.

🤖 Generated with Claude Code

https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Restore ESLint and gate releases on lint success

🐞 Bug fix ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Restores ESLint by aligning TypeScript with the shared configuration's supported peer range.
• Adds a reusable lint workflow that blocks releases on lint failures.
• Applies behavior-preserving fixes to newly surfaced test lint violations.

Diagram

graph TD
  EVENT["Workflow trigger"] --> PIPELINE["Test release workflow"] --> LINT["Reusable lint workflow"] --> INSTALL["pnpm install"] --> ESLINT["ESLint"] -->|success required| RELEASE["Release job"]
  TOOLCHAIN["Pinned toolchain"] --> INSTALL

Loading

High-Level Assessment

The current approach is appropriate: pinning TypeScript within the shared configuration's declared peer range repairs the immediate incompatibility, while the reusable workflow prevents recurrence from going unnoticed. Upgrading the lint stack for TypeScript 7 or using package overrides would add risk and obscure compatibility constraints without improving this fix.

Files changed (5) +311 / -481

Tests (1) +7 / -7

filemenu.jsResolve file menu test lint violations +7/-7

Resolve file menu test lint violations

• Reformats the render helper to satisfy line-break and line-length rules. Marks synchronous Mocha hooks and tests as async to satisfy the restored shared lint configuration without changing assertions.

static/tests/backend/specs/filemenu.js

Other (4) +304 / -474

lint.ymlAdd reusable ESLint workflow +35/-0

Add reusable ESLint workflow

• Adds a callable GitHub Actions workflow that installs Node.js, pnpm, cached dependencies, and runs the repository lint script.

.github/workflows/lint.yml

test-and-release.ymlGate releases on the lint workflow +4/-0

Gate releases on the lint workflow

• Invokes the reusable lint workflow alongside backend and frontend tests. Adds lint completion to the release job's required dependencies.

.github/workflows/test-and-release.yml

package.jsonAlign the ESLint configuration and TypeScript versions +2/-2

Align the ESLint configuration and TypeScript versions

• Upgrades eslint-config-etherpad to version 5 and pins TypeScript to the supported 6.0 minor line, preventing the TypeScript 7 compiler API incompatibility.

package.json

pnpm-lock.yamlRegenerate the compatible lint dependency graph +263/-472

Regenerate the compatible lint dependency graph

• Resolves eslint-config-etherpad 5.0.2 with TypeScript 6.0.3 and updates the associated TypeScript ESLint packages and plugins. Removes TypeScript 7's platform-specific native packages.

pnpm-lock.yaml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Pull request events skip lint checks 🐞 Bug ≡ Correctness

Description

lint.yml exposes only workflow_call, and its new caller in test-and-release.yml is triggered
only by push and workflow_dispatch. Opening, reopening, or synchronizing a pull request
therefore does not invoke this lint path, particularly leaving fork contributions without a
base-repository lint run.

Code

.github/workflows/test-and-release.yml[R17-18]

+  lint:
+    uses: ./.github/workflows/lint.yml

Evidence

The parent workflow declares only push and workflow_dispatch, while the added lint job calls a
reusable workflow whose only trigger is workflow_call; no workflow in this path subscribes to
pull_request.

.github/workflows/test-and-release.yml[1-9]
.github/workflows/test-and-release.yml[17-19]
.github/workflows/lint.yml[3-4]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly connected lint workflow is only reached from a caller that handles pushes and manual dispatches, so pull request events do not invoke lint in the base repository.
## Fix Focus Areas
- .github/workflows/test-and-release.yml[1-9]
- .github/workflows/test-and-release.yml[17-19]
## Recommended Fix
Add a `pull_request` trigger to `test-and-release.yml` so its lint job runs for pull request activity while the existing branch condition continues to prevent releases outside the default branch.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗