Repository navigation
Conversation
…ersation - Conversations: a search box above the filters matches names, companies, email addresses and the text of every email, reply and waiting draft. Every word typed must match, and each filter's count follows the search. - Outbox: a search box on the review desk narrows the waiting emails and the scheduled, sent and didn't-send lists. The match count sits inside the box, "/" focuses it and Esc clears it. "Approve all" is hidden while a search is on, since it approves the whole queue, not only what's shown. - "Review in Outbox" on a conversation's drafted reply now opens the Outbox on that draft instead of the first email in the queue. It clears any leftover search so the draft is visible, and keeps an edit in progress. - Search boxes on every tab: placeholder shortened to "Search" (the full description moves to aria-label), so it's never cut off; the box is as wide as the Outbox list it filters and goes full width on a phone. Signed-off-by: golensio <352001403+golensio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Search on the Conversations tab. A search box above the filters matches names, companies, email addresses, and the text of every cold email, reply, Sellbird answer and waiting draft. Every word typed has to match, and each filter's count follows the search, so you can see when a match is hiding under another filter.
Search in the Outbox. A search box on the review desk narrows the emails waiting for approval, and the scheduled, sent and didn't-send lists below it, by recipient, company, contact, subject, body, campaign, or why Sellbird held an email. The match count ("2 of 5") sits inside the box.
/jumps to it and Esc clears it. A, R, E and J/K work on the matching emails only."Review in Outbox" opens that draft. The button under a conversation's drafted reply used to open the Outbox on the first email in the queue, so you had to find the reply yourself. It now lands on that conversation's draft. It clears any leftover Outbox search so the draft is visible, and it won't throw away an edit in progress.
Search boxes on every tab. The placeholder is now just "Search", since the longer hints were cut off. The full description moves to
aria-labelfor screen readers. The box matches the width of the Outbox list it filters, the browser's own clear button is turned off because it collided with the count (Esc replaces it), and on a phone the box goes full width.Before and after
All screenshots use invented demo data on
.testdomains.Outbox
Conversations
"Review in Outbox" on Jordan's drafted reply
Notes
app.js,app.css,index.html. No API or database changes. Search runs over what each tab already loads, so Conversations covers the latest 100 conversations, the same set the tab shows today.Tests
tests/test_dashboard_conversation_search.py(27 cases) runs the matchers under node: every field is searchable, every word must match, missing fields are fine, "Approve all" is hidden while searching, and "Review in Outbox" passes the draft id.