Skip to content

feat: improve lighest purple shade for contrast - #439

Merged
mergify[bot] merged 1 commit into
mainfrom
wrap-2262-hover-contrast-on-refill-buttons-looks-bad
Oct 2, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
wrap-2262-hover-contrast-on-refill-buttons-looks-bad

Conversation

@annie-seaward

@annie-seaward annie-seaward commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Color contrast between purple icons and background hover color is quite low (not an a11y issue, but looks visually off to my eye).

Using a lighter shade pulled from Figma design versions (not sure why there is divergence between Figma and Live shades anyway?? - and therefore do we need wrap sign-off??)

@mergify
mergify Bot requested review from a team and JoshTheWanderer and removed request for a team September 30, 2026 17:09
@mergify
mergify Bot requested a review from a team September 30, 2026 17:09
@github-actions

Copy link
Copy Markdown

✅⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ CSS stylelint 1 0 0 1.73s
✅ EDITORCONFIG editorconfig-checker 1 0 0 0.01s
✅ REPOSITORY checkov yes no no 25.54s
⚠️ REPOSITORY gitleaks yes 6 no 7.28s
✅ REPOSITORY git_diff yes no no 0.05s
✅ REPOSITORY secretlint yes no no 3.24s
✅ REPOSITORY syft yes no no 7.37s
✅ REPOSITORY trivy-sbom yes no no 4.49s
✅ REPOSITORY trufflehog yes no no 103.33s

Detailed Issues

⚠️ REPOSITORY / gitleaks - 6 errors
○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

Finding:     VITE_MARKER_KEY: REDACTED
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     3.553509
File:        .github/workflows/deploy.yml
Line:        37
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-04-24T11:48:15Z
Fingerprint: 2c76e7174c25cd560f5bceb4c095e253417e0634:.github/workflows/deploy.yml:generic-api-key:37
Link:        https://github.com/etchteam/recycling-locator/blob/2c76e7174c25cd560f5bceb4c095e253417e0634/.github/workflows/deploy.yml#L37

Finding:     VITE_MARKER_KEY: REDACTED
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     3.553509
File:        .github/workflows/deploy.yml
Line:        39
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-03-16T16:55:19Z
Fingerprint: 1556c5d76bf2feb9f1745484fa07fae4ea6fac75:.github/workflows/deploy.yml:generic-api-key:39
Link:        https://github.com/etchteam/recycling-locator/blob/1556c5d76bf2feb9f1745484fa07fae4ea6fac75/.github/workflows/deploy.yml#L39

Finding:     MARKER_KEY: REDACTED
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     3.553509
File:        .github/workflows/deploy.yml
Line:        37
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-03-12T05:46:34Z
Fingerprint: edb2bd3b00e33ba9eef6326d3c8cd6a657649c68:.github/workflows/deploy.yml:generic-api-key:37
Link:        https://github.com/etchteam/recycling-locator/blob/edb2bd3b00e33ba9eef6326d3c8cd6a657649c68/.github/workflows/deploy.yml#L37

Finding:     ...E_PACKAGE_VERSION=1 VITE_HERE_MAPS_PLACES_KEY=REDACTED npm run build
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     4.693479
File:        .github/workflows/ci.yml
Line:        69
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-02-24T21:21:34Z
Fingerprint: 80649ba25c2a8f92eb7825b81355d08292efa0c8:.github/workflows/ci.yml:generic-api-key:69
Link:        https://github.com/etchteam/recycling-locator/blob/80649ba25c2a8f92eb7825b81355d08292efa0c8/.github/workflows/ci.yml#L69

Finding:     ...E_PACKAGE_VERSION=1 VITE_HERE_MAPS_PLACES_KEY=REDACTED npm test
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     4.693479
File:        .github/workflows/ci.yml
Line:        73
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-02-24T12:01:19Z
Fingerprint: 82ebd091a8e8fd8e381d88003189fff7c22f8555:.github/workflows/ci.yml:generic-api-key:73
Link:        https://github.com/etchteam/recycling-locator/blob/82ebd091a8e8fd8e381d88003189fff7c22f8555/.github/workflows/ci.yml#L73

Finding:     ...E_PACKAGE_VERSION=1 VITE_HERE_MAPS_PLACES_KEY=REDACTED npm test
Secret:      REDACTED
RuleID:      generic-api-key
Entropy:     4.693479
File:        .github/workflows/ci.yml
Line:        73
Commit:      HIDDEN_BY_MEGALINTERAuthor:      Dan Webb
Email:       dan@etch.co
Date:        2024-02-24T11:56:43Z
Fingerprint: 219c47440fa90bc250dcb661929edcaf69f8c33b:.github/workflows/ci.yml:generic-api-key:73
Link:        https://github.com/etchteam/recycling-locator/blob/219c47440fa90bc250dcb661929edcaf69f8c33b/.github/workflows/ci.yml#L73

5:10PM INF 1361 commits scanned.
5:10PM INF scanned ~8128558 bytes (8.13 MB) in 7.01s
5:10PM WRN leaks found: 6

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@sonarqubecloud

Copy link
Copy Markdown

@mergify
mergify Bot merged commit e2be74b into main Oct 2, 2026
10 checks passed
@mergify
mergify Bot requested a review from a team October 2, 2026 11:08
@mergify
mergify Bot deleted the wrap-2262-hover-contrast-on-refill-buttons-looks-bad branch October 2, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants