Compatible with authentication versions below 3.3.0#115
Closed
tzfun wants to merge 1 commit into
Closed
Conversation
Signed-off-by: beifengtz <beifengtz@qq.com>
belltoy
requested changes
Dec 12, 2025
| if let Some(token) = self.token.read_unpoisoned().as_ref() { | ||
| request.headers_mut().insert(AUTHORIZATION, token.clone()); | ||
| // Compatible with authentication versions below 3.3.0 (excluding 3.3.0). In older versions, the header key is 'token'. | ||
| request.headers_mut().insert("token", token.clone()); |
Contributor
There was a problem hiding this comment.
Thank you, @tzfun
I have made a similar change in #106, but not merged yet.
I prefer to use token to replace authorization header instead of keeping both.
In etcd server, they use token as the for GRPC auth header, authorization is a compatible fallback (Swagger header). And furthermore, in etcd grpcproxy mode, it only uses token.
Author
There was a problem hiding this comment.
Okay, you can ignore this PR now. I'm looking forward to the new version release. 👍
belltoy
force-pushed
the
master
branch
2 times, most recently
from
9a46eb1 to
2e99c37
Compare
Contributor
|
Close due to #106 has merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detail see issue #114