docs: document x509 keyUsage and extendedKeyUsage for etcd TLS#1123
docs: document x509 keyUsage and extendedKeyUsage for etcd TLS#1123Aditya7880900936 wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Aditya7880900936 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Aditya7880900936. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hi @ronaldngounou @ivanvc , Have a look in this PR and feel free to suggest any changes |
|
/ok-to-test |
|
@Aditya7880900936 Can you please fix the lint failures in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/1123/pull-website-lint/2023798261906673664 ? |
|
@ronaldngounou , i corrected the lint failure kindly check it |
|
Thanks. Could you please squash your commits as well? |
Aditya7880900936
force-pushed
the
docs/tls-x509-keyusage
branch
from
25e9174 to
63b11ca
Compare
Document recommended keyUsage and extendedKeyUsage values for CA, server, client, and peer certificates used to secure etcd transport. Peer certificates are used for mutual TLS and therefore require both serverAuth and clientAuth extended key usages. Fixes etcd-io/etcd#19799. Signed-off-by: Aditya7880900936 <adityasanskarsrivastav788@gmail.com>
Aditya7880900936
force-pushed
the
docs/tls-x509-keyusage
branch
from
63b11ca to
1fdcdae
Compare
|
Hi @ronaldngounou , I have implmenetd the squash changes you have suggested earlier , feel free to have any suggestions |
|
/lgtm |
|
@ivanvc @siyuanfoundation can you have a quick sanity check look at the info here to make sure it's technically correct? |
4 participants
This PR documents recommended X.509
keyUsageandextendedKeyUsagevalues for certificates used to secure etcd transport (CA, server,
client, and peer).
This clarifies existing behavior enforced by Go's
crypto/tlsandcrypto/x509libraries.Fixes etcd-io/etcd#19799
Docs-only change.