feat: set a CPU request on the etcd container for Burstable QoS#418
Conversation
Set a CPU request (never a limit) of 50m on the etcd container so the pod is Burstable instead of BestEffort. Without a request etcd gets the kernel-floor cpu.shares of 2 and is the first workload evicted under node pressure; a small request raises the scheduling floor without ever throttling etcd. Overridable via a new --etcd-cpu-request flag (default "50m"). Empty string or "0" applies no request (original BestEffort behavior); a malformed quantity is treated as unset so a bad flag cannot wedge cluster creation. Controller-level knob, no API/CRD change. Documented in the flag help and docs/operator-flags.md (linked from the README). Table-driven test asserts the request is applied (with no CPU limit), an override is honored, and empty/"0"/malformed disable it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Xavier Lange <xrlange@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xrl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @xrl. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What
Set a CPU request (never a limit) on the etcd container so the pod runs as Burstable instead of BestEffort QoS.
Without a CPU request, the etcd container gets the kernel-floor
cpu.sharesof 2 and is the first workload evicted / starved under node CPU pressure. A small request (default50m) raises the scheduling floor without ever throttling etcd (no limit is set).Details
--etcd-cpu-request(default"50m")."0"applies no request, preserving the original BestEffort behavior.docs/operator-flags.md(linked from the README)."0"/ malformed values disable it.Sequencing / precedence
This introduces an operator-set etcd CPU-request / QoS default. It should land after #398 (podspec-scheduling). Any user-set resources must take precedence over this operator default — that layering is not yet reconciled against #398, which is why this is opened as a draft.
DCO
Commit is DCO signed-off (
Signed-off-by: Xavier Lange <xrlange@gmail.com>).