Repository navigation
feat: embed line crops in PDF exports - #10
Merged
Merged
Conversation
Owner
|
Thank you very much for your time and collaboration!! Hope to see you soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
This update makes PDF exports easier to verify against the OCR source by embedding each generated line crop directly above its corresponding transcription.
The change keeps export_to_pdf() backwards compatible, scales images while preserving aspect ratio, handles page breaks, delays crop cleanup until PDF generation is complete, and validates the one-to-one relationship between transcript lines and image crops.
Regression tests cover image embedding, invalid line/image counts, end-to-end PDF generation, and temporary crop cleanup.