[ESRTEST-30704] Add #update to Index#68
Open
sergio-bobillier wants to merge 2 commits into
Open
Conversation
Moves the Script class out of the QueryBuilder namespace and leaves it directly under Elasticsearch. This is done because there are scripted elements in Elasticsearch outside the context of queries, such as scripts that run when documents are updated or reindexed. Therefore it makes sense to have the Script class in a more general namespace.
The method allows the caller to update a document in the index by providing the document ID and the updated fields or an update script.
sergio-bobillier
force-pushed
the
sb-ESRTEST-30704-add-update-to-index
branch
from
40023bb to
04fb56e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
#updatemethod to theIndexclass. This method allows the caller to update a document by ID. The caller can either provide a partial document with the updates they want to make or an update script.Additional changes:
The addition of the
#updatemethod made it evident that theQueryBuilder::Scriptclass should actually be directly under theElasticsearchnamespace, since it can be used outside the context of query construction. A commit is included to handle that. To keep backwards compatibility an alias is being added in place of the old class with a deprecation notice.The objective is to avoid causing a string of releases in downstream tools.