[JAY-656] Add a way to access the Elasticsearch cluster's node-related statistics#30
Merged
Merged
Conversation
sergio-bobillier
force-pushed
the
sb-JAY-656-nodes-stats
branch
from
de1f486 to
25b7e01
Compare
sheputis
reviewed
May 22, 2025
sheputis
approved these changes
May 22, 2025
albertoberto
left a comment
albertoberto
left a comment
There was a problem hiding this comment.
Second commit: "holds" instead of "hold" In the first line of the commit message
albertoberto
left a comment
albertoberto
left a comment
There was a problem hiding this comment.
I reviewed all 5 commits but I guess if I hit "Approve" then I'd approve the whole PR
This is being done because the index-related statistics are not the only statistics that the API can deliver. In an upcoming commit node-related statistics will be needed, then a single #response method will no longer be suitable.
The class holds information about the storage space available on one of the nodes that make up the Elasticsearch cluster. It will be used in an upcoming commit to provide the user access to said information.
The class holds information about one of the nodes that make up the Elasticsearch cluster. For the moment it only provides the #storage method, which gives the caller access to storage-related information about the node. The class will be used in an upcoming commit to give the user access to said data through the Elasticsearch::Client class.
The class holds the information for each of the nodes that make up the Elasticsearch cluster. It acts as a collection of Node objects, one for each node. The class uses a lazy enumerator to avoid instantiating Node objects needlessly, they are only initialized when they are accessed. The class will be used in an upcoming commit to give the user access to node-related statistics through the Elasticsearch::Client class.
The method returns an instance of Elasticsearch::Stats::Nodes, a class which allows the caller to access information about the nodes that make up the Elasticsearch cluster.
sergio-bobillier
force-pushed
the
sb-JAY-656-nodes-stats
branch
from
25b7e01 to
04139af
Compare
albertoberto
approved these changes
May 26, 2025
sheputis
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the necessary classes to allow the user to access the Elasticsearch cluster's node-related statistics. For the moment only information about the nodes' storage can be accessed. More information will probably be accessible in the future.
The
Storageclass has ben equipped with a+operator in order to allow clients to easily calculate the total storage on the cluster, by adding together the storage data for each of the nodes.