Skip to content

RFC: Noglib BSPs in menuconfig#758

Open
tore-espressif wants to merge 1 commit intomasterfrom
feat/noglib_menuconfig
Open

RFC: Noglib BSPs in menuconfig#758
tore-espressif wants to merge 1 commit intomasterfrom
feat/noglib_menuconfig

Conversation

@tore-espressif
Copy link
Copy Markdown
Collaborator

@tore-espressif tore-espressif commented Apr 10, 2026

Change description

This PR adds condition to esp_lvgl_port dependency on a new BSP_LVGL_INTEGRATION menuconfig symbol.
In the source code, already available BSP_CONFIG_NO_GRAPHIC_LIB macro is used to #ifdef the graphical library code.

User can convert a standard BSP to BSP_noglib with simple change in menuconfig and running idf.py update-dependencies

You can see the main advantage from the size of this diff; only minimal changes are required to make this work.

Follow-ups

  • Implement for all BSPs
  • Update docs
  • Remove old noglib CI
  • Decide on default value of BSP_LVGL_INTEGRATION

Note

Medium Risk
Moderate risk because it changes build-time configuration and dependency resolution (conditionally pulling esp_lvgl_port), which can affect compile/link outcomes across projects. Also introduces a new Kconfig toggle that may alter default binary contents and size.

Overview
Adds a new CONFIG_BSP_LVGL_INTEGRATION Kconfig option (default enabled) that controls whether the BSP is built with LVGL support.

When disabled, the component manifest conditionally omits the espressif/esp_lvgl_port dependency and bsp/config.h derives BSP_CONFIG_NO_GRAPHIC_LIB from sdkconfig for #ifdef-based exclusion.

Renames the uSD “format on mount fail” Kconfig symbol to BSP_SD_FORMAT_ON_MOUNT_FAIL (aligning naming with the existing CONFIG_BSP_SD_FORMAT_ON_MOUNT_FAIL usage).

Reviewed by Cursor Bugbot for commit 8ed743e. Bugbot is set up for automated code reviews on this repo. Configure here.

@tore-espressif tore-espressif self-assigned this Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8ed743e.

♻️ This comment has been updated with latest results.

@tore-espressif tore-espressif force-pushed the feat/noglib_menuconfig branch from 04b987a to 6e0735e Compare April 10, 2026 14:13
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is kicking off a free cloud agent to fix this issue. This run is complimentary, but you can enable autofix for all future PRs in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6e0735e. Configure here.

@tore-espressif tore-espressif force-pushed the feat/noglib_menuconfig branch from 6e0735e to 8ed743e Compare April 13, 2026 07:31
- bsp

dependencies:
idf: ">=5.2"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but I think that conditions in YML are supported from IDF 5.3

@espzav
Copy link
Copy Markdown
Collaborator

espzav commented Apr 14, 2026

@tore-espressif Thank you for this proposal. It looks good. You can update branch - CI should be fixed on master.

@espzav
Copy link
Copy Markdown
Collaborator

espzav commented Apr 14, 2026

Follow-up: We can make NoGlib example into BSP and run it in CI and BSP Wall too :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants