Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 8ed743e. ♻️ This comment has been updated with latest results. |
04b987a to
6e0735e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is kicking off a free cloud agent to fix this issue. This run is complimentary, but you can enable autofix for all future PRs in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e0735e. Configure here.
6e0735e to
8ed743e
Compare
| - bsp | ||
|
|
||
| dependencies: | ||
| idf: ">=5.2" |
There was a problem hiding this comment.
I am not sure, but I think that conditions in YML are supported from IDF 5.3
|
@tore-espressif Thank you for this proposal. It looks good. You can update branch - CI should be fixed on master. |
|
Follow-up: We can make NoGlib example into BSP and run it in CI and BSP Wall too :-) |

Change description
This PR adds condition to
esp_lvgl_portdependency on a newBSP_LVGL_INTEGRATIONmenuconfig symbol.In the source code, already available
BSP_CONFIG_NO_GRAPHIC_LIBmacro is used to #ifdef the graphical library code.User can convert a standard BSP to BSP_noglib with simple change in menuconfig and running
idf.py update-dependenciesYou can see the main advantage from the size of this diff; only minimal changes are required to make this work.
Follow-ups
BSP_LVGL_INTEGRATIONNote
Medium Risk
Moderate risk because it changes build-time configuration and dependency resolution (conditionally pulling
esp_lvgl_port), which can affect compile/link outcomes across projects. Also introduces a new Kconfig toggle that may alter default binary contents and size.Overview
Adds a new
CONFIG_BSP_LVGL_INTEGRATIONKconfig option (default enabled) that controls whether the BSP is built with LVGL support.When disabled, the component manifest conditionally omits the
espressif/esp_lvgl_portdependency andbsp/config.hderivesBSP_CONFIG_NO_GRAPHIC_LIBfromsdkconfigfor#ifdef-based exclusion.Renames the uSD “format on mount fail” Kconfig symbol to
BSP_SD_FORMAT_ON_MOUNT_FAIL(aligning naming with the existingCONFIG_BSP_SD_FORMAT_ON_MOUNT_FAILusage).Reviewed by Cursor Bugbot for commit 8ed743e. Bugbot is set up for automated code reviews on this repo. Configure here.