feat(icm42670): add support for spi interface in icm42670 (BSP-782)#725
Open
benjibst wants to merge 4 commits intoespressif:masterfrom
Open
feat(icm42670): add support for spi interface in icm42670 (BSP-782)#725benjibst wants to merge 4 commits intoespressif:masterfrom
benjibst wants to merge 4 commits intoespressif:masterfrom
Conversation
Collaborator
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Added support for spi communication with ICM42670.
Note
Medium Risk
Introduces a new SPI transport path and refactors low-level
icm42670_read/icm42670_writeto switch between I2C and SPI, which could impact existing I2C behavior if transaction formatting or device selection is wrong. Changes are contained to the sensor driver and build metadata, with no security-sensitive logic.Overview
Adds SPI communication support to the
icm42670sensor driver alongside existing I2C support.Introduces
icm42670_create_spi()and extends the internal device struct to track SPI vs I2C, routingicm42670_read/icm42670_writethroughspi_device_transmit()when SPI is selected (including MSB read flag handling) and cleaning up SPI devices inicm42670_delete(). Device-ID presence checking is centralized in a newcheck_device_present()helper.Updates component metadata to require
esp_driver_spi(IDF >= 5.3) and refreshes README/idf_component.ymldescriptions to state I2C/SPI support.Written by Cursor Bugbot for commit 57286f0. This will update automatically on new commits. Configure here.