Skip to content

feat(icm42670): add support for spi interface in icm42670 (BSP-782)#725

Open
benjibst wants to merge 4 commits intoespressif:masterfrom
benjibst:master
Open

feat(icm42670): add support for spi interface in icm42670 (BSP-782)#725
benjibst wants to merge 4 commits intoespressif:masterfrom
benjibst:master

Conversation

@benjibst
Copy link
Copy Markdown

@benjibst benjibst commented Feb 14, 2026

Change description

Added support for spi communication with ICM42670.


Note

Medium Risk
Introduces a new SPI transport path and refactors low-level icm42670_read/icm42670_write to switch between I2C and SPI, which could impact existing I2C behavior if transaction formatting or device selection is wrong. Changes are contained to the sensor driver and build metadata, with no security-sensitive logic.

Overview
Adds SPI communication support to the icm42670 sensor driver alongside existing I2C support.

Introduces icm42670_create_spi() and extends the internal device struct to track SPI vs I2C, routing icm42670_read/icm42670_write through spi_device_transmit() when SPI is selected (including MSB read flag handling) and cleaning up SPI devices in icm42670_delete(). Device-ID presence checking is centralized in a new check_device_present() helper.

Updates component metadata to require esp_driver_spi (IDF >= 5.3) and refreshes README/idf_component.yml descriptions to state I2C/SPI support.

Written by Cursor Bugbot for commit 57286f0. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 14, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title feat(icm42670): add support for spi interface in icm42670 feat(icm42670): add support for spi interface in icm42670 (BSP-782) Feb 14, 2026
@PetrESP
Copy link
Copy Markdown
Collaborator

PetrESP commented Feb 17, 2026

Hello @benjibst,

Thank you for this pull request! Could you please install pre-commit to correctly format your code? You can follow our guide here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants