Repository navigation
Keep the table name when a row's url is the bare Hub marker - #110
Conversation
Four table.csv rows store "https://huggingface.co/" as their url. _resolve_huggingface read that as a full repository URL and returned its empty tail as the repo id, so snapshot_download raised HFValidationError on "". The scheduled model test failed on two of them (byan/librispeech_asr_train_asr_conformer_..., reazon-research/ reazonspeech-espnet-v1); the two pyf98 speechcommands SLU rows had the same fault but are not loaded by the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the main change: preserving the table name when the URL is the bare Hugging Face Hub marker. Description check The description is directly related to the changeset. It explains the failure, root cause, fix, test coverage, and validation results. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 63.91% 63.93% +0.02%
==========================================
Files 5 5
Lines 1258 1259 +1
==========================================
+ Hits 804 805 +1
Misses 454 454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What failed
The scheduled Model test run (run 39211176651) failed on 2 of 146 models with
HFValidationError: ... '':byan/librispeech_asr_train_asr_conformer_raw_bpe_batch_bins30000000_accum_grad3_optim_conflr0.001_spreazon-research/reazonspeech-espnet-v1Cause
Four
table.csvrows storehttps://huggingface.co/(the marker with a trailing slash) as their url._resolve_huggingfacetreated it as a full repository URL and returned its empty tail as the repo id, sosnapshot_download("")was called. The twopyf98/speechcommands_*SLU rows have the same fault but the model test does not load them.Fix
Only take the URL tail as the repo id when it is non-empty; otherwise keep the table name. Added
test_table_row_with_bare_hub_marker_url_keeps_its_name, which fails without the change ({'cache_dir': ''}) and passes with it.Checked locally
pytest test/: 180 passed🤖 Generated with Claude Code