Repository navigation
Install the TTS extra the model test needs - #108
Conversation
The weekly run has been failing 116 of 146 models, every one of them on a package from espnet's [tts] extra: pyworld, g2p_en, jaconv, pypinyin. Since the dependency split a bare espnet install carries inference dependencies only, and this workflow installs a bare espnet. The extra goes in the requirement rather than a second pip line, because 'pip install espnet[tts]' afterwards would fetch espnet from PyPI over the git checkout the matrix asked for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 5 5
Lines 1258 1258
=======================================
Hits 804 804
Misses 454 454 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe model test workflow now installs the ESPnet Git package with the Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This CI-only change enables dependencies for the existing TTS model tests and does not alter production behavior. No actionable merge-blocking risk is established; a model-test run can confirm the intended coverage. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is confined to model-test CI and adds dependencies required by existing TTS tests. Triggers and credential handling are unchanged, and no token compromise is established. Effective job permissions and credential exposure remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The weekly Model test failed 116 of 146 models after 5h15m. Every failure is a missing package, and every one of them is in espnet's
[tts]extra:Since espnet's dependency split, a bare install carries the inference dependencies only, and this workflow installs a bare espnet from git. The TTS models it then loads need
pyworld,pypinyin,espnet-g2p-enandjaconv, which are exactly what[tts]adds.The extra goes into the requirement itself:
rather than a second
pip install "espnet[tts]", which would fetch espnet from PyPI over the git checkout the matrix just asked for. Checked that the string parses as a PEP 508 requirement carrying both the extra and the URL.This removes the cause of all 116 failures; whether every model then loads is what the next run will say, and that run is five hours, so it is not something this PR can show. Worth a
workflow_dispatchafter merge rather than waiting for Monday.The unit-test workflow installs the same way but is green: it does not build TTS models.
🤖 Generated with Claude Code