Skip to content

Ignore local config/ directory#1215

Open
jesserockz wants to merge 1 commit into
mainfrom
jesserockz-2026-299
Open

Ignore local config/ directory#1215
jesserockz wants to merge 1 commit into
mainfrom
jesserockz-2026-299

Conversation

@jesserockz
Copy link
Copy Markdown
Member

@jesserockz jesserockz commented Jun 5, 2026

What does this implement/fix?

Adds config/ to .gitignore so a local config/ working directory (alongside the already-ignored configs/) isn't accidentally committed.

All ESPHome documentation refers to config as the directory so it makes sense to add this here too

Related issue or feature (if applicable):

  • fixes

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — docs
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Frontend coordination

  • No frontend change needed
  • Companion frontend PR: esphome/device-builder-frontend#

Checklist

  • The code change is tested and works locally.
  • Pre-commit hooks pass (ruff, codespell, yaml/json/python checks).
  • Tests have been added or updated under tests/ where applicable.
  • components.index.json / definitions/components/*.json have not been hand-edited (regenerate via script/sync_components.py if a sync is needed).
  • Architecture-level changes are reflected in docs/ARCHITECTURE.md and/or docs/API.md.

Copilot AI review requested due to automatic review settings June 5, 2026 04:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions github-actions Bot added the maintenance Maintenance / chores label Jun 5, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 5, 2026

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing jesserockz-2026-299 (ff7163b) with main (9e136f2)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.42%. Comparing base (9e136f2) to head (ff7163b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         217      217           
  Lines       16140    16140           
=======================================
  Hits        16047    16047           
  Misses         93       93           
Flag Coverage Δ
py3.12 99.39% <ø> (ø)
py3.14 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance / chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants