Repository navigation
fix: claim hygiene (webp bug, limitations, ARM bench) - #21
Merged
Merged
Conversation
Vendored stb_image v2.30 cannot decode WebP, so a folder containing .webp files made dinov2-cli exit 1 and the dedup script aborted. Restrict the scan list to formats stb_image actually decodes and document conversion hints (sips, heif-convert, ffmpeg) for HEIC/WebP/RAW in the example README.
State plainly that image decode is vendored stb_image only (no HEIC, WebP, RAW, or AVIF), embeddings are image-to-image rather than CLIP-style text queries, and classification is ImageNet-1k only.
The 3x faster / 4x less memory figures come from the i9-14900HX measurement kept as historical context in docs/benchmarks.md, not from the committed Ubuntu workflow row.
Add a workflow_dispatch platform choice (ubuntu-latest default, ubuntu-24.04-arm for ARM numbers), wire it into runs-on, record it in benchmark_provenance.txt, and forward it to scripts/bench.sh --platform so the results header names the runner label.
Record the small f16 measurement from the new ARM64 bench path: 133.8 ms mean (8.2 stddev, 128-148, 96 MB peak RSS) at 4 threads on a 4-CPU aarch64 runner, same GGUF sha256 as the x64 row. Split the provenance block per platform and note the rows are not directly comparable across thread counts.
espetro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marketing assets workstream branch. Generated with Devin