Skip to content

SpiDma read/write: copy as little as possible #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MabezDev merged 18 commits into from
May 6, 2026
Merged

SpiDma read/write: copy as little as possible #5290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cce294d
Skip empty operations
bugadani Mar 31, 2026
fef9107
Use a lifetimed buffer internally
bugadani Mar 31, 2026
bec2d81
Extract copying functions
bugadani Mar 31, 2026
c72a2a1
Minimal copying async read/write
bugadani Mar 31, 2026
8da6276
Update blocking functions
bugadani Apr 1, 2026
3c03428
Reuse constant
bugadani May 4, 2026
50913bd
Do not write back the owner bit
bugadani Apr 1, 2026
45dc8f4
Force copying unaligned buffer on ESP32
bugadani Apr 1, 2026
02e7cec
Tweak documentation
bugadani Apr 7, 2026
989b9d4
Simplify PCNT setup in SPI tests
bugadani Apr 7, 2026
c1945a1
Leave cache writeback to the prepare impl
bugadani Apr 13, 2026
4c89e8a
Rewrite tests to use PSRAM if available, disable optimization on S2
bugadani Apr 7, 2026
365e4cd
Tweak ESP32 and S2
bugadani Apr 14, 2026
ae63ece
Fix building test
bugadani May 4, 2026
a062e1b
Refine changes
bugadani May 4, 2026
bda254e
Changelog
bugadani May 5, 2026
98a40c4
Do not enable defmt for the tests
bugadani May 5, 2026
cea8726
Add one more descriptor
bugadani May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- The clock frequency accessor functions no longer need to lock the clock tree (#5461)
- SPI: `SpiDmaBus` has been merged into `SpiDma`. `with_buffers` now returns `SpiDma` directly, and the buffer-taking transfer methods have been renamed to `read_buffer`, `write_buffer`, `transfer_buffers`, `half_duplex_read_buffer` and `half_duplex_write_buffer` to avoid conflicts with the `SpiBus` trait methods. (#5272)
- SPI: `SpiDma` will now skip copying into the internal buffers unless necessary (#5290)

### Fixed

Expand Down
Loading
Loading