Add half_duplex_write_async method to SpiDmaBus#5135
Add half_duplex_write_async method to SpiDmaBus#5135BestClaws wants to merge 4 commits intoesp-rs:mainfrom
Conversation
|
I think you can also add the read async too |
I think you should add some if you want to make this part of the PR description true ;) |
I may have misunderstood what HIL means from other reference PRs. Just tested it on hardware. let me update the pr description. On a side note: both sync/async half_duplex_write methods seem to rendering the single SPI methods like transaction buggy giving bad data without error. although I need to verify that fact is actually the case |
|
Declaring "HIL test" on a PR (besides being lazy wording) means that the relevant change is tested in CI. In this case, that needs a new test case - and this PR will eventually need a new test case. You don't need to add any, but we would appreciate if you did. |
|
New commits in main has made this PR unmergable. Please resolve the conflicts. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
SpiDmaBus has convenience async methods but lacks half duplex write async version. the existing version does a busy poll which is not desired in async environments
Testing
Verified on my hardware. no test code in place.