make the S3 ADC less bad#4514
Draft
dimpolo wants to merge 1 commit intoesp-rs:mainfrom
Draft
Conversation
|
New commits in main has made this PR unmergable. Please resolve the conflicts. |
github-actions
Bot
added
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for testing purposes only.
On my S3 board the efuse init code was
2267.This lead to the 0-300mV range to read as 0.
The init code obtained from manual calibration is
1999which leads to much better results.This reverts part of #4286.
This was necessary to make manual calibration work.
Could someone check if this indeed improves the ADC values and then try to understand why the efuse init code is off by so much.
Maybe we could actually get some official docs for what all the regs do 🙏