Merged
Conversation
| 1. You can clone espp somewhere on your computer and then point your project to | ||
| its `components` directory to use any of the components it contains, similar | ||
| to the step above. | ||
|
|
There was a problem hiding this comment.
Line 79 contains whitespace on an otherwise blank line. Consider removing the trailing spaces to avoid noisy diffs and potential markdown formatting/lint issues.
Suggested change
Comment on lines
+80
to
+82
| Note: you should ensure that you clone recursively or run `git submodule | ||
| update --init --recursive` to ensure that you have the latest versions of all | ||
| the submodules which are required to build the components in this repository. |
There was a problem hiding this comment.
The note about submodules is a bit misleading/inconsistent: git submodule update --init --recursive checks out the commits pinned by this repo (not necessarily the "latest" versions from submodule remotes), and "clone recursively" would be clearer as git clone --recurse-submodules. Also consider matching the existing capitalization/style used elsewhere in this README (e.g., "NOTE:").
Suggested change
| Note: you should ensure that you clone recursively or run `git submodule | |
| update --init --recursive` to ensure that you have the latest versions of all | |
| the submodules which are required to build the components in this repository. | |
| NOTE: you should ensure that you clone with submodules, for example by using | |
| `git clone --recurse-submodules`, or, if you have already cloned the | |
| repository, by running `git submodule update --init --recursive` to ensure | |
| that all required submodules are checked out at the commits pinned by this | |
| repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.