Remove x-typescript-types header for *.mjs route#1323
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors error handling for build metadata retrieval in the ESM router, specifically affecting routes that serve built .mjs files. The change consolidates nested error checking into inline conditional statements while modifying how errors are handled when retrieving TypeScript type definitions metadata.
Changes:
- Refactored metadata retrieval error handling from explicit error checks to nested inline conditionals
- Changed error behavior to silently ignore all metadata retrieval errors instead of returning 500 errors for non-NotFound database errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert #1317