Skip to content

chore: add lint:unused script to run Knip#371

Merged
fasttime merged 9 commits intomainfrom
chore/configure-knip
Mar 17, 2026
Merged

chore: add lint:unused script to run Knip#371
fasttime merged 9 commits intomainfrom
chore/configure-knip

Conversation

@Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Adds Knip to check for unused exports, unused dependencies, and missing dependencies

What changes did you make? (Give an overview)

  • Added knip.json config and a root lint:unused script.
  • Added a "Lint Files, Dependencies, & Exports" step to our CI.
  • Removed unused BASELINE_FALSE export

Related Issues

eslint/js#695

Is there anything you'd like reviewers to focus on?

@Pixel998 Pixel998 requested a review from a team as a code owner January 29, 2026 23:55
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 29, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Feb 9, 2026
@DMartens DMartens moved this from Needs Triage to Implementing in Triage Feb 11, 2026
@github-actions github-actions bot removed the Stale label Feb 11, 2026
nzakas
nzakas previously approved these changes Feb 16, 2026
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @DMartens to verify his feedback has been addressed before merging.

@nzakas nzakas moved this from Implementing to Second Review Needed in Triage Feb 16, 2026
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 20, 2026
DMartens
DMartens previously approved these changes Feb 20, 2026
Copy link

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks (left open as a review from the TSC was requested).

@Tanujkanti4441
Copy link
Contributor

Hi @Pixel998, could you take a look at the conflicts?

@fasttime
Copy link
Member

fasttime commented Mar 6, 2026

There's again a merge conflict now.

"devDependencies": {
"@arethetypeswrong/cli": "^0.18.2",
"@eslint/json": "^1.1.0",
"@types/node": "^20.19.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/node is a peer dependency of Knip.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 6fb7bac into main Mar 17, 2026
33 checks passed
@fasttime fasttime deleted the chore/configure-knip branch March 17, 2026 05:50
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

6 participants