Improve error messages for invalid hiccup in emit#37
Open
Improve error messages for invalid hiccup in emit#37
Conversation
Add a :default emit method that catches unexpected dispatch values with a descriptive message (special-casing bare keywords with a "wrap it in a vector" hint). Also validate component return values against the parser before emitting, so invalid hiccup from a component identifies the component and what it returned instead of producing "No method in multimethod 'emit' for dispatch value: null".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:defaultemit method that catches any unexpected dispatch value with a descriptive error message, special-casing bare keywords with a "wrap it in a vector" suggestionNo method in multimethod 'emit' for dispatch value: nullwith no contextTest plan
component-invalid-hiccup-error-test: verifies error message and ex-data for components returning invalid hiccup