Add streaming Writer support (html-write, page-write)#36
Open
Add streaming Writer support (html-write, page-write)#36
Conversation
Extract emit-parsed! helper from html, then add html-write and page-write that write directly to a java.io.Writer instead of building a string in memory. Enables faster time-to-first-byte and lower memory usage for large pages. Closes #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit-parsed!helper that centralizes parse -> validate -> emit logichtmlto delegate toemit-parsed!(behavioral no-op, all existing tests pass)html-writeandpage-writethat write directly to ajava.io.Writerinstead of building a string in memoryThis enables faster time-to-first-byte and lower memory usage for large or lazily-generated pages. The approach works because all
emitmultimethods already write exclusively through anappend!function argument — streaming support just provides a differentappend!that writes to a Writer.Design decisions
WriternotOutputStream: HTML is characters, not bytes. Callers wrap OutputStream inOutputStreamWriter(one-liner)spit+io/copyconventionhtmlandpagebehave identicallyCloses #35
Test plan
html-write-test: basic output, equivalence withhtml, opts passthrough, component supportpage-write-test: doctype prefix + content