Resolve small bug with document.querySelector on empty strings#16
Open
varun-tandon wants to merge 1 commit intoerrorception:masterfrom
Open
Resolve small bug with document.querySelector on empty strings#16varun-tandon wants to merge 1 commit intoerrorception:masterfrom
varun-tandon wants to merge 1 commit intoerrorception:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rakeshpai! Thanks so much for creating this library.
I was trying to use the library with my own project, and I noticed an issue where the
getMinimalSelectorscall may calldocument.querySelectoron an empty string -- which causes puppeteer to crash.I think this is a simple one line fix! Hope this helps, and please do let me know if you would prefer to make this change in a different way :)