feat(builtins): add ReportFindings to BUILTIN_TOOLS - #63
Merged
Merged
Conversation
ReportFindings is a built-in Claude Code tool for surfacing structured code-review findings to the host UI. Skills that include it in allowed-tools (e.g. code-review skills) were getting a false tool-unknown diagnostic. Adding it to BUILTIN_TOOLS suppresses that false positive. Tests added for both the set membership and the tool-unknown rule.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReportFindingstoBUILTIN_TOOLSinsrc/builtins.tsReportFindingsis a built-in Claude Code tool that surfaces structured code-review findings to the host UI; skills that list it inallowed-toolswere getting a falsetool-unknowndiagnostictest/builtins.test.ts) and the tool-unknown rule (test/checks.test.ts)Test plan
npm run lintpasses (tsc --noEmit)npm run buildpassesnpm testpasses: 255 tests across 10 test fileshttps://claude.ai/code/session_01PYVLtq8eQK5jaxsZTUczum
Generated by Claude Code