feat(match): add spanId and correlationId to VOLATILE_KEYS - #36
Merged
Merged
Conversation
Both spanId and correlationId are observability/tracing IDs generated
per-request. The fuzzy match tier already normalized them via ID_KEY,
but normalizedMatch (one tier earlier) did not strip them, so two
requests differing only in spanId or correlationId would fall through
to the fuzzy tier unnecessarily.
Adding them to VOLATILE_KEYS makes normalizedMatch consistent with the
existing treatment of requestId and traceId.
Four new test cases cover: spanId alone, correlationId alone, both
keys combined with other volatile keys, and near-miss keys ('span',
'correlation') that must NOT be stripped.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
spanIdandcorrelationIdare per-request observability/tracing IDs that change on every call, just likerequestIdandtraceId(which are already inVOLATILE_KEYS). Without this fix, two otherwise-identical requests differing only inspanIdorcorrelationIdfall throughnormalizedMatchand must be caught by thefuzzyMatchtier, even thoughfuzzydoes normalize them viaID_KEY. Promoting these two keys one tier earlier is purely a correctness improvement: replay becomes more lenient at the right tier, and the match chain is shorter for the common case.What
"spanId"and"correlationId"toVOLATILE_KEYSinsrc/match.ts.stripVolatilepicks up the new keys automatically.Tests
test/match.volatile.test.ts:spanIdalone:exactMatchreturns false,normalizedMatchreturns true.correlationIdalone: same pattern.traceIdandrequestId: all stripped together.spanandcorrelation(not in the Set):normalizedMatchcorrectly returns false.Self-merge gate
src/index.tsnot modified)test/match.volatile.test.ts)Generated by Claude Code