Repository navigation
test(params): add params.rs covering all positions where $param can appear - #29
Merged
Merged
Conversation
…appear Existing parse.rs covered only one param case (WHERE equality). This suite adds 12 tests for: lhs comparison, boolean conjunction, IN expression, standalone RETURN, arithmetic, list literal, LIMIT, SKIP, LIMIT+SKIP together, ORDER BY, underscore names, and multiple distinct params in a single query.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expr::Param(String)is a first-class AST node (grammar rule:param = ${ "$" ~ ident }) but the test suite had only one param case inparse.rs(WHERE equality). All other positions where a param can legally appear -- LIMIT, SKIP, ORDER BY, list literals, arithmetic, boolean conjunctions, the lhs of a comparison, and multi-param queries -- were untested. This closes that gap without touching any source files.What
tests/params.rswith 12 focused integration tests covering:$paramon the lhs of a<=comparison$paramin AND-chained conjunctions (two distinct param names)$paramas the rhs ofIN$paramas a standalone RETURN item$paramin arithmetic (u.score + $bonus)$paramelements inside a list literal (IN [$a, $b, $c])$paramin LIMIT$paramin SKIP$paramin LIMIT and SKIP together$paramin ORDER BY expressionTests
cargo test-- all 12 new tests pass, 0 regressions across 186 existing testscargo clippy --all-targets -- -D warnings-- cleancargo fmt --check-- cleanSelf-merge gate
https://claude.ai/code/session_011bbaY2nq45AHdK694aMSuw
Generated by Claude Code