test: node_patterns suite -- direction, inline props, multi-label, multi-type - #28
Merged
Merged
Conversation
…multi-label, multi-type Adds tests/node_patterns.rs with 13 tests for pattern-shape features that were implemented in the parser but had no dedicated test file: - Incoming and undirected relationship direction variants, with a plan display roundtrip check for all three directions - Multiple labels on a node pattern (labels: Vec<String>) - Inline node property maps (single, multi-key, parameter value) - Inline relationship property maps - Plan lowering: inline node props produce Filter over Scan; inline rel props produce Filter over Expand - Multiple relationship types with pipe syntax (:A|B) - Anonymous anchor node (no var) and anonymous relationship (no var)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/node_patterns.rs(13 tests, 239 LOC) covering pattern-shape features that were implemented in the parser but had no dedicated test file.New coverage:
<-) and undirected (--) relationship direction variants, plus a plan-display roundtrip check for all three directionsu:Admin:User){id: $uid})[:KNOWS {since: 2020}])Filter(Scan); inline rel props lower toFilter(Expand(...)):KNOWS|FOLLOWS)-[]->): verifies the var fields areNoneSelf-merge gate checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01RLjXteaU6ui7BRdZ2NvzNE
Generated by Claude Code