Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a memory guard to all functions in the function set that can grow the size of a value. The guarded functions throw an exception if the returned value exceeds the hardcoded threshold of 50 KiB.
Also adds and evolutionary statistic that counts the number of individuals per generation that exceed the memory guard on at least one case.
This feature is implemented with clj-memory-meter which requires the jvm-opt
-Djdk.attach.allowAttachSelfto be set. This has been added to this project's aliases that are used to run tests and benchmark runs but users that runcbgp-liteas a library will need to set the jvm-opt themselves.This PR has been tested on a small number of runs for count-odds, get-vals-of-key, and sum-vector-vals.