ssh: Close socket in kex_strict_helper to prevent eaddrinuse#11275
Open
u3s wants to merge 1 commit into
Open
Conversation
The kex_strict_helper function creates a TCP connection for each
test iteration but never closes the client socket. On OpenBSD, the
lingering sockets in TIME_WAIT cause gen_tcp:connect to fail with
eaddrinuse on subsequent iterations due to ephemeral port collision
with {reuseaddr, true}.
Add close_socket to the test message sequence so the socket is
released before the next iteration begins
u3s
added
team:PS
Contributor
CT Test Results 2 files 29 suites 28m 52s ⏱️ Results for commit 1560e8c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kex_strict_helper function creates a TCP connection for each test iteration but never closes the client socket. On OpenBSD, the lingering sockets in TIME_WAIT cause gen_tcp:connect to fail with eaddrinuse on subsequent iterations due to ephemeral port collision with {reuseaddr, true}.
Add close_socket to the test message sequence so the socket is released before the next iteration begins