public_key: Skip DSA tests when crypto lacks DSA support#11273
Open
u3s wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 18 suites 4m 6s ⏱️ Results for commit e0d34e2. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
LibreSSL (shipped by OpenBSD) disables DSA, causing
public_key_SUITE:dsa_sign_verify, public_key_SUITE:pkix_path_validation,
and pkits_SUITE:valid_dsa_signature to crash with
{notsup, "Unsupported algorithm"} on OpenBSD 7.8.
Add init_per_testcase guards that check
crypto:supports(public_keys) for dss, matching the pattern
already used for eddsa, mldsa, and slh_dsa tests.
For pkix_path_validation, fall back to RSA keys when DSA is
unavailable since the test validates path validation logic,
not the specific key algorithm.
u3s
force-pushed
the
kuba/public_key/test_fixup_dsa_guard
branch
from
5d62a9c to
e0d34e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibreSSL (shipped by OpenBSD) disables DSA, causing public_key_SUITE:dsa_sign_verify, public_key_SUITE:pkix_path_validation, and pkits_SUITE:valid_dsa_signature to crash with
{notsup, "Unsupported algorithm"} on OpenBSD 7.8.
Add init_per_testcase guards that check
crypto:supports(public_keys) for dss, matching the pattern already used for eddsa, mldsa, and slh_dsa tests.
For pkix_path_validation, fall back to RSA keys when DSA is unavailable since the test validates path validation logic, not the specific key algorithm.