Skip to content

bxor: Fix raising of system_limit exception #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjorng merged 1 commit into from
Jun 23, 2026
+22 −1
Merged

bxor: Fix raising of system_limit exception #11269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion erts/emulator/beam/erl_arith.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,8 +1364,11 @@ Eterm erts_bxor(Process* p, Eterm arg1, Eterm arg2)
need = BIG_NEED_SIZE(MAX(big_size(arg1), big_size(arg2)) + 1);
hp = HeapFragOnlyAlloc(p, need);
arg1 = big_bxor(arg1, arg2, hp);
ASSERT(is_not_nil(arg1));
maybe_shrink(p, hp, arg1, need);
if (is_nil(arg1)) {
p->freason = SYSTEM_LIMIT;
return THE_NON_VALUE;
}
return arg1;
}

Expand Down
18 changes: 18 additions & 0 deletions erts/emulator/test/big_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@


-include_lib("common_test/include/ct.hrl").
-include_lib("stdlib/include/assert.hrl").

suite() ->
[{ct_hooks,[ts_install_cth]},
Expand Down Expand Up @@ -380,6 +381,23 @@ system_limit(Config) when is_list(Config) ->
{'EXIT',{system_limit,_}} = (catch id(1) bsl (1 bsl 45)),
{'EXIT',{system_limit,_}} = (catch id(1) bsl (1 bsl 69)),

?assertError(system_limit, Maxbig bxor -1),
?assertError(system_limit, apply(erlang, id('bxor'), [Maxbig,-1])),
if
Maxbig bxor -1 -> error(should_fail);
true -> ok
end,

%% bnot -Maxbig should not raise an exception.
MaxMinusOne = Maxbig - 1,
MinusMaxbig = -Maxbig,
MaxMinusOne = bnot MinusMaxbig,
MaxMinusOne = apply(erlang, id('bnot'), [MinusMaxbig]),

%% -Maxbig bxor -1 should not raise an exception.
MaxMinusOne = MinusMaxbig bxor -1,
MaxMinusOne = apply(erlang, id('bxor'), [MinusMaxbig,-1]),

%% There should be no system_limit exception when shifting a zero.
0 = id(0) bsl (1 bsl 128),
0 = id(0) bsr -(1 bsl 128),
Expand Down
Loading