stdlib: document float map key encoding in json#11252
Open
mjc wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 100 suites 1h 0m 23s ⏱️ Results for commit 8a59d51. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
1b87bbe to
8a59d51
Compare
Contributor
Author
|
force push: I had accidentally had 2 commits which is silly for a mostly-documentation pr. |
michalmuskala
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jsonencoder has accepted Erlang maps with float keys since the originaljsonmodule was added in 66a771e (Add json module). The runtime key dispatcher already handles floats withkey(Key, _Encode) when is_float(Key) -> [$", encode_float(Key), $"], which emits the key as a JSON object name.JSON object names are strings, so this does not add non-string keys to JSON. It updates the public
encode_map/1type and theencode/1data mapping table to describe the existing Erlang input behavior, and adds encode tests for both the default and checked map encoding paths.