Skip to content

Fix handling of truncation bit vs. truncated sections in inet_res#11247

Open
RaimoNiskanen wants to merge 1 commit into
erlang:maint-28from
RaimoNiskanen:raimo/kernel/inet-res-vc-fallback/OTP-20199
Open

Fix handling of truncation bit vs. truncated sections in inet_res#11247
RaimoNiskanen wants to merge 1 commit into
erlang:maint-28from
RaimoNiskanen:raimo/kernel/inet-res-vc-fallback/OTP-20199

Conversation

@RaimoNiskanen

Copy link
Copy Markdown
Contributor

Also mend the truncation fallback test case that has gotten incorrect when DNS server praxis gradually changed...

Nowdays DNS servers avoid sending non-essential RR:s if that makes the reply fit in 512 bytes, so the actual answer has to be larger than 512 bytes; add more MX records.

The bug was introduced in OTP 28.4.2, PR #10864.

Closes #11114.

Also mend the truncation fallback test case that has gotten
incorrect when DNS server praxis gradually changed...

Nowdays DNS servers avoid sending non-essential RR:s if that makes
the reply fit in 512 bytes, so the actual answer has to be larger
than 512 bytes; add more MX records.
@RaimoNiskanen RaimoNiskanen added this to the OTP-29.1 milestone Jun 16, 2026
@RaimoNiskanen RaimoNiskanen requested review from bmk and dgud June 16, 2026 09:33
@RaimoNiskanen RaimoNiskanen self-assigned this Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

CT Test Results

    2 files     72 suites   1h 9m 40s ⏱️
1 692 tests 1 344 ✅ 347 💤 1 ❌
1 944 runs  1 538 ✅ 405 💤 1 ❌

For more details on these failures, see this check.

Results for commit 05ab20e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inet_res:getbyname/4 not falling back to TCP for large UDP packets

2 participants