timer: fixes and improvements#11241
Open
Maria-12648430 wants to merge 2 commits into
Open
Conversation
Contributor
CT Test Results 2 files 100 suites 1h 7m 18s ⏱️ Results for commit 7e4a3c5. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
fcd3067 to
7e4a3c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit in this PR fixes two inconsistencies:
timer:send_after(0, PidOrRegName, Msg)was used andPidOrRegNamewas anatomwhich was not registered at the time of the call, abadargexception was raised instead of returning{error, badarg}like everywhere elsetimer:send_after(Time, Pid, Msg)was used, wherePidwas a local pid andTimewould exceed theerlang:start_timerinterval (see here), abadargexception was raised instead of returning{error, badarg}like everywhere elseIt also optimizes two
timer:send_aftercases:timer:send_after(Time, RegName, Msg)(whereRegNameis a locally registered name) has been changed to useerlang:send_afterdirectly and not go through the timer server processtimer:send_after(Time, {RegName, Node}, Msg)(whereRegNamea registered name at nodeNode, andNodeis the local node) has been changed to useerlang:send_afterdirectly and not go through the timer server processThe second commit in this PR contains documentation fixes and rewordings in order to read more modern.