Kuba/public key/minor hardening/otp 20197#11239
Open
u3s wants to merge 2 commits into
Open
Conversation
Contributor
CT Test Results 2 files 18 suites 4m 45s ⏱️ Results for commit ff1cb70. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
force-pushed
the
kuba/public_key/minor_hardening/OTP-20197
branch
from
8d31998 to
768a606
Compare
Replace == with crypto:hash_equals/2 for issuerNameHash, issuerKeyHash, and byKey responder ID comparisons in pubkey_ocsp.erl. The == operator short-circuits on the first differing byte, creating a timing side-channel. Affected locations: - match_single_response/4: issuerNameHash and issuerKeyHash - is_responder_cert/2: byKey SHA-1 hash
Add a 100 KB size guard in decode_response/1 to reject
oversized input before calling der_decode. This prevents
unbounded memory allocation from crafted OCSP responses.
The 100 KB limit is aligned with OpenSSL's
OSSL_HTTP_DEFAULT_MAX_RESP_LEN. Typical OCSP responses are
1–5 KB; multi-stapling with 10 certs reaches ~50 KB.
Oversized input returns:
{error, {ocsp_response_too_large, Size}}
u3s
force-pushed
the
kuba/public_key/minor_hardening/OTP-20197
branch
from
768a606 to
ff1cb70
Compare
u3s
added
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.