Repository navigation
Add: Chunk handling API - #11
Open
Trident35ro wants to merge 4 commits into
Open
Trident35ro wants to merge 4 commits into
Trident35ro wants to merge 4 commits into
Conversation
Allows modders to modify chunk generation or chunk generation rules.
ChunkControl doesn't use Unity's Start() message; it implements the game's custom OrderedStart interface instead (Start_0()/Start_1()). Patching a literal "Start" made Harmony.PatchAll() throw and abort before patching anything else in the assembly.
The postfix declared pass-through params "X"/"Z" (HostGetChunk's real params are chunkX/chunkZ, and Harmony binds pass-through params by name) and typed __result as Chunk when HostGetChunk actually returns ChunkData. Harmony's IL patcher threw "Parameter X not found" and aborted PatchAll before patching anything else in the assembly. ChunkLoadedEvent updated to carry ChunkData instead of Chunk to match, and the postfix now actually fires it through EventBus instead of constructing and discarding it.
eris-webserv
requested changes
Aug 17, 2026
eris-webserv
left a comment
eris-webserv
left a comment
Owner
There was a problem hiding this comment.
Needs to be de-conflicted.
Contributor
Author
|
The conflict has been solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows modders to modify chunk generation or chunk generation rules.