Promote dev to main: Updates_20260801

.github/workflows/claude-code-review.yml

@@ -0,0 +1,82 @@
+name: Claude Code Review
+
+on:
+  pull_request:
+    # Only auto-review PRs into dev. Promotions from dev to main re-package
+    # already-reviewed work, and comment @claude on any PR for an on-demand review.
+    branches: [dev]
+    types: [opened, synchronize, ready_for_review, reopened]
+    # To limit reviews to certain files, uncomment and adjust:
+    # paths:
+    #   - "**/*.sql"
+    #   - "**/*.ps1"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
+  cancel-in-progress: true
+
+jobs:
+  claude-review:
+    # Skip draft PRs (reviewed when marked ready) and fork PRs: GitHub does not
+    # expose repo secrets to workflows triggered from forks, so the review can
+    # only run on same-repo branches. Use @claude comments for fork PRs.
+    if: ${{ !github.event.pull_request.draft && github.event.pull_request.head.repo.full_name == github.repository }}
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+      id-token: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code Review
+        uses: anthropics/claude-code-action@v1
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
+          track_progress: true
+          prompt: |
+            REPO: ${{ github.repository }}
+            PR NUMBER: ${{ github.event.pull_request.number }}
+
+            This repository contains Erik Darling's SQL Server troubleshooting stored
+            procedures. Most changes are to large, self-contained T-SQL stored
+            procedures, plus PowerShell tooling and CI scripts. The repository
+            CLAUDE.md is the canonical T-SQL style guide.
+
+            Review this pull request with these priorities:
+
+            1. Correctness: logic errors, NULL handling, dynamic SQL construction
+               (quoting, QUOTENAME, parameterized sp_executesql), cursor handling,
+               error handling, and overflow safety (COUNT_BIG, ROWCOUNT_BIG).
+            2. SQL Server version compatibility: procedures support a range of
+               versions (generally 2016 through 2025, plus Azure SQL DB and Managed
+               Instance where the procedure documents support). Flag newer T-SQL
+               syntax (STRING_AGG, CONCAT_WS, GREATEST/LEAST, TRIM, etc.) or DMV
+               columns used without the version/feature gating patterns the
+               procedure already uses elsewhere.
+            3. Self-containment: procedures must not gain dependencies on helper
+               functions, views, or other database objects.
+            4. Style: flag clear CLAUDE.md violations (tabs, -- comments instead of
+               /* */ blocks, abbreviated data types or keywords, missing table
+               aliases, missing semicolons). Do not nitpick.
+
+            Repo-specific rules:
+            - Install-All/DarlingData.sql is auto-generated by CI. If this PR edits
+              it directly, flag that as a blocking problem: only per-procedure
+              source files should change.
+            - The @version / @version_date lines in procedures only change in
+              release PRs from the maintainer (erikdarlingdata). If any other PR
+              bumps them, ask for that to be reverted.
+
+            The PR branch is already checked out in the current working directory.
+
+            Use inline comments for specific issues and one summary comment for the
+            overall review. Only the GitHub comments you post will be seen, so put
+            all feedback there rather than in a normal response. If the changes look
+            good, say so briefly and do not invent problems.
+
+          claude_args: |
+            --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"

.github/workflows/claude.yml

@@ -0,0 +1,39 @@
+name: Claude Code
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_review_comment:
+    types: [created]
+  issues:
+    types: [opened, assigned]
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  claude:
+    # Only users with write access to the repo can trigger this; the action
+    # enforces that check on the commenting user. This is also the way to get a
+    # review on fork PRs, where the automatic review workflow cannot run.
+    if: |
+      (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
+      (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
+      (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+      issues: write
+      id-token: write
+      actions: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 1
+
+      - name: Run Claude Code
+        uses: anthropics/claude-code-action@v1
+        with:
+          claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}

.github/workflows/sql-tests.yml

@@ -41,7 +41,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install sqlcmd
+      - name: Install sqlcmd tools
         run: |
           # Ubuntu 24.04 runners have Microsoft repo pre-configured; avoid Signed-By conflicts
           if ! grep -rql 'packages.microsoft.com' /etc/apt/sources.list.d/ 2>/dev/null; then
@@ -52,6 +52,29 @@ jobs:
           sudo apt-get update
           sudo ACCEPT_EULA=Y apt-get install -y mssql-tools18
 
+      - name: Install go-sqlcmd (for the assertion harnesses)
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          # The Python assertion harnesses were written and validated against the
+          # go-based sqlcmd, not mssql-tools18, so install that to avoid
+          # output-parsing differences. It is not in the apt repo for these
+          # runners, so pull the latest linux-amd64 release binary.
+          set -euxo pipefail
+          assets=$(curl -fsSL -H "Authorization: Bearer $GH_TOKEN" \
+            https://api.github.com/repos/microsoft/go-sqlcmd/releases/latest \
+            | grep -oE 'https://[^"]+' | grep -iE 'linux[-_]amd64.*\.tar\.(bz2|gz)$')
+          echo "$assets"
+          url=$(echo "$assets" | head -1)
+          test -n "$url"
+          mkdir -p /tmp/gosqlcmd
+          curl -fsSL -o /tmp/gosqlcmd.tar "$url"
+          tar -xf /tmp/gosqlcmd.tar -C /tmp/gosqlcmd
+          bin=$(find /tmp/gosqlcmd -type f -name sqlcmd | head -1)
+          test -n "$bin"
+          sudo install "$bin" /usr/local/bin/sqlcmd
+          /usr/local/bin/sqlcmd --version
+
       - name: Create test database
         env:
           SA_PASSWORD: CI_Test#2026!
@@ -105,3 +128,102 @@ jobs:
           SA_PASSWORD: CI_Test#2026!
         run: |
           /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P "$SA_PASSWORD" -C -No -b -d DarlingData_CI_Test -i ".github/sql/test_basic_execution.sql"
+
+      # The harnesses connect to master and run EXECUTE dbo.sp_... there (as they
+      # do on a local box, where these procs live in master), so install the
+      # bundle into master too. The smoke tests above use DarlingData_CI_Test.
+      - name: Install procedures into master (for the assertion harnesses)
+        env:
+          SA_PASSWORD: CI_Test#2026!
+        run: |
+          /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P "$SA_PASSWORD" -C -No -b -d master -i "Install-All/DarlingData.sql"
+
+      # Assertion harnesses. These EXECUTE the output the procedures generate
+      # (findings, session DDL) rather than just running them, which is what
+      # catches the "reads correctly but is wrong when run" bugs the smoke tests
+      # above cannot. They are self-contained (build and drop their own scratch
+      # databases, sessions, and config), except sp_IndexCleanup, which needs a
+      # StackOverflow2013.dbo.Users table that the fixture step below creates.
+      # They use the go-based sqlcmd via the SQLCMD_* environment overrides.
+      # Encryption is disabled (-N disable): the modern Go TLS stack rejects the
+      # SQL Server 2017 container's self-signed certificate outright, and -C
+      # (trust cert) does not bypass that; there is nothing to secure on a
+      # localhost throwaway container.
+      - name: sp_PerfCheck assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_PerfCheck/tests/run_tests.py --server localhost --password "$SA_PASSWORD"
+
+      - name: sp_HumanEvents assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_HumanEvents/tests/run_tests.py --server localhost --password "$SA_PASSWORD"
+
+      # sp_IndexCleanup's harness needs a StackOverflow2013 with a Users table.
+      # The containers have no such database, so build a faithful-schema
+      # synthetic stand-in. Real values are irrelevant: the harness forces its
+      # index reads and every rule is structural (dedupe / overlap / usage
+      # floor). See sp_IndexCleanup/tests/fixture_stackoverflow2013.sql.
+      - name: Create StackOverflow2013 fixture (for the sp_IndexCleanup harness)
+        env:
+          SA_PASSWORD: CI_Test#2026!
+        run: |
+          /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P "$SA_PASSWORD" -C -No -b -i "sp_IndexCleanup/tests/fixture_stackoverflow2013.sql"
+
+      # Four runners: adversarial synthetic tables, the Users dedupe cases
+      # (which also EXECUTE every generated MERGE/DISABLE script), rule coverage
+      # in its own scratch databases, and the no-database-access preflight guard.
+      - name: sp_IndexCleanup assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_IndexCleanup/tests/run_tests.py --server localhost --password "$SA_PASSWORD"
+          python3 sp_IndexCleanup/tests/fixture_cases_test.py --server localhost --password "$SA_PASSWORD"
+          python3 sp_IndexCleanup/tests/rule_coverage_test.py --server localhost --password "$SA_PASSWORD"
+          python3 sp_IndexCleanup/tests/no_access_test.py --server localhost --password "$SA_PASSWORD"
+
+      # ReproBuilder is fully portable: every plan is an embedded string constant
+      # and its one table-dependent case builds a fixture in tempdb. No user
+      # database needed.
+      - name: sp_QueryReproBuilder assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_QueryReproBuilder/tests/run_tests.py --server localhost --password "$SA_PASSWORD"
+
+      # sp_LogHunter builds an xp_readerrorlog command string per search term
+      # and executes each one, swallowing any that throw into #errors rather
+      # than raising them -- so a broken generated command looks like a clean,
+      # empty result set. The harness asserts #errors stays empty across the
+      # matrix, and writes a marker to the error log via RAISERROR ... WITH LOG
+      # as a positive control so the absence assertions cannot pass vacuously.
+      - name: sp_LogHunter assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_LogHunter/tests/run_tests.py --server localhost --password "$SA_PASSWORD"
+
+      # sp_QuickieStore is ~16k lines of dynamic SQL whose shape changes with
+      # almost every parameter, so this is a parameter matrix: all 39 sort
+      # orders, the wait filters, execution types, query types and the
+      # expert/format grid, each of which executes the statement it just built.
+      # It creates and drops its own Query Store scratch database.
+      - name: sp_QuickieStore assertion harness
+        env:
+          SA_PASSWORD: CI_Test#2026!
+          SQLCMD_BIN: /usr/local/bin/sqlcmd
+          SQLCMD_CONN_ARGS: "-C -N disable"
+        run: |
+          python3 sp_QuickieStore/tests/run_tests.py --server localhost --password "$SA_PASSWORD"

.gitignore

@@ -8,3 +8,5 @@
 *.lock
 .DS_Store
 .claude/
+__pycache__/
+*.pyc